1121250 - [Privacy Panel][Remote Privacy Protection] RPP Locate function will not send any return message or lock the device if there is no WiFi or Data network connection

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Martin Shuman [:Marty]]

Attachment: logcat-RPP-Locate-No-Network.txt

Description:
If the DUT does not have a connection to a Data or WiFi network when it receives an RPP Locate message, the device will not lock itself, and it will not send any respond message.
If the device is unable to acquire GPS location data, the user will expect the device to still lock itself and send back a message indicating it received the command, but can't find its location.
   
Repro Steps:
1) Update a  device to BuildID: 20150113010202
2) Make sure the DUT does not have a connection to WiFi or Data networks.
3) Open Settings and navigate to Privacy Panel.
4) Progress past the Guided Tour, and select Remote Privacy Protection
5) Configure a Passphrase and enable the RPP Locate function 
6) From a second device, send 'RPP locate <PASSPHRASE>' in an SMS to the DUT
  
Actual:
The device doesn't lock itself, and sends no response back to the second device, indicating success or failure.
  
Expected: 
The device will always lock itself and send a response message indicating success or otherwise, regardless of network conditions.
  
Environmental Variables:
Device:  3.0
BuildID: 20150113010202
Gaia: 9946a490a9264b42e65385d703b28fa055ab2d42
Gecko: 3d846527576f
Gonk: a814b2e2dfdda7140cb3a357617dc4fbb1435e76
Version: 38.0a1 (3.0)
Firmware: V18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0
  
Repro frequency: 6/6
See attached: video clip (URL), logcat

------------------------------

This issue DOES occur on Flame 2.2
The device doesn't lock itself, and sends no response back to the second device, indicating success or failure.

Environmental Variables:
Device: Flame KK
BuildID: 20150112010228
Gaia: f5e481d4caf9ffa561720a6fc9cf521a28bd8439
Gecko: bb8d6034f5f2
Gonk: a814b2e2dfdda7140cb3a357617dc4fbb1435e76
Version: 37.0a1 (KK)
Firmware: V18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

------------------------------

This issue does NOT occur on Flame 2.1
Privacy Panel was not implemented on this branch.

Environmental Variables:
Device: Flame 2.1
BuildID: 20150112001215
Gaia: 1975241ac29f723479e6c60b2bf74ebed54da91a
Gecko: 0863fe4b75c3
Gonk: a814b2e2dfdda7140cb3a357617dc4fbb1435e76
Version: 34.0 (2.1)
Firmware: V18D
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Comment 1

[Kevin Grandon :kgrandon]

It looks like we see the following in the logs: 01-13 15:45:58.892: W/Privacy Panel(9799): Content JS WARN: Error while trying to locate a phone: Position acquisition timed out

I think we end up here in a dead-end: https://github.com/mozilla-b2g/gaia/blob/0f7bb156969c5c838ff90ebc88d7691fc4d94310/apps/privacy-panel/js/sms/main.js#L191

Comment 2

[GitHub Autolander Bot]

Attachment: [PullReq] martasect:bug_1121250 to mozilla-b2g:master

Comment 3

[Kevin Grandon :kgrandon]

Comment on attachment 8552056 [details] [review]
[PullReq] martasect:bug_1121250 to mozilla-b2g:master

R+. I'll go ahead and land this for now, but I would recommend following this up with a test.

Comment 4

[Kevin Grandon :kgrandon]

In master: https://github.com/mozilla-b2g/gaia/commit/7b5f695c279beed4a47e39489eb8ce721f36ab27

Comment 5

[Yeojin Chung [:YeojinC]]

This issue STILL reproduces on Flame Master.

Result: The device does not lock and send any response to the second device without data or Wi-Fi connection.

Device: Flame Master (319mb, full flash)
Build ID: 20150126010231
Gaia: 0f662dffef27599443cfcd790c2b39190a2b35c8
Gecko: fa91879c8428
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0