Closed Bug 1121363 Opened 5 years ago Closed 5 years ago

Remove more straggling PJS bits

Categories

(Core :: JavaScript Engine, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla38

People

(Reporter: lth, Assigned: lth)

References

Details

Attachments

(2 files)

By an oversight, this function was not removed earlier.  grep finds these instances:

./src/builtin/TestingFunctions.cpp:1226:js::testingFunc_inParallelSection(JSContext *cx, unsigned argc, jsval *vp)
./src/builtin/TestingFunctions.cpp:2459:    JS_FN_HELP("inParallelSection", testingFunc_inParallelSection, 0, 0,
./src/builtin/TestingFunctions.cpp:2460:"inParallelSection()",
./src/builtin/TestingFunctions.h:18:testingFunc_inParallelSection(JSContext *cx, unsigned argc, Value *vp);
By an oversight, lots of other little bits (and some larger bits) were also not removed earlier.  I've filed bugs for some of them (bug 1121433, bug 1121434, bug 1121435) but the easy fixes are handled here.
Summary: Remove testingFunc_inParallelSection → Remove more straggling PJS bits
Hannes, can you check that my changes to TraceLogger don't do anything bad?
Attachment #8548870 - Flags: review?(shu)
Attachment #8548870 - Flags: feedback?(hv1989)
Comment on attachment 8548870 [details] [diff] [review]
Remove yet more PJS code

Review of attachment 8548870 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good wrt Tracelogger. Seems like TraceLogger_ParallelSafetyAnalysis was never used or did you already remove that?
Attachment #8548870 - Flags: feedback?(hv1989) → feedback+
(In reply to Hannes Verschore [:h4writer] from comment #3)
> Comment on attachment 8548870 [details] [diff] [review]
> Remove yet more PJS code
> 
> Review of attachment 8548870 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Looks good wrt Tracelogger. Seems like TraceLogger_ParallelSafetyAnalysis
> was never used or did you already remove that?

Any use would have been removed by an earlier patch, when the bulk of the JIT was cleaned out.
Comment on attachment 8548870 [details] [diff] [review]
Remove yet more PJS code

Review of attachment 8548870 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsobj.cpp
@@ -3286,5 @@
> -    if (name->isIndex(&index))
> -        return GetElementPure(cx, obj, index, vp);
> -
> -    return GetPropertyPure(cx, obj, NameToId(name->asPropertyName()), vp);
> -}

Hm, seeing how LookupPropertyPure is independently useful, I wonder if these pure variants would also be independently useful. I suppose it doesn't hurt to remove now and add them back later should new users arise, rather than let them rot in the codebase.
Attachment #8548870 - Flags: review?(shu) → review+
Might as well just post it in this bug. Turned out there wasn't really anything
big I needed to do with VMFunctions. Sorry for not r+ing your deleting this a
while back, Lars.
Attachment #8549272 - Flags: review?(lhansen)
Comment on attachment 8549272 [details] [diff] [review]
Simplify VMFunction context matching.

Review of attachment 8549272 [details] [diff] [review]:
-----------------------------------------------------------------

I'll land this this morning when I land the other one.
Attachment #8549272 - Flags: review?(lhansen) → review+
You need to log in before you can comment on or make changes to this bug.