Closed Bug 1121658 Opened 5 years ago Closed 5 years ago

Remove DestroyDecodedStream() from MediaDecoder::SetDormantIfNecessary()

Categories

(Core :: Audio/Video, defect, P1)

Product:
Core
Component:
Audio/Video
Platform:
ARM
Gonk (Firefox OS)
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla38
Tracking Flags:
Tracking Status
firefox36 --- fixed
firefox37 --- fixed
firefox38 --- fixed

People

(Reporter: sotaro, Assigned: sotaro)

References

Details

Attachments

(1 file)

patch - Remove DestroyDecodedStream() from MediaDecoder::SetDormantIfNecessary()
1.61 KB, patch
roc
: review+
Sylvestre
: approval-mozilla-aurora+
Sylvestre
: approval-mozilla-beta+
Details | Diff | Splinter Review 
+++ This bug was initially created as a clone of Bug #1121064 +++

Call DestroyDecodedStream() in MediaDecoder::SetDormantIfNecessary() seem not a correct way to stop MediaStream in this situation.
Assignee: nobody → sotaro.ikeda.g
Attachment #8549129 - Flags: review?(cpearce)
Blocks: 1050031
No longer blocks: 1121064
Comment on attachment 8549129 [details] [diff] [review]
patch - Remove DestroyDecodedStream() from MediaDecoder::SetDormantIfNecessary()

Review of attachment 8549129 [details] [diff] [review]:
-----------------------------------------------------------------

Probably better to get Roc to check this, since it touches MediaStreams.
Attachment #8549129 - Flags: review?(cpearce) → review?(roc)
https://hg.mozilla.org/mozilla-central/rev/56824531bfec
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
Comment on attachment 8549129 [details] [diff] [review]
patch - Remove DestroyDecodedStream() from MediaDecoder::SetDormantIfNecessary()

Approval Request Comment
[Feature/regressing bug #]: MSE
[User impact if declined]: Youtube playback can use more resources. Less consistent testing.
[Describe test coverage new/current, TreeHerder]: Landed on m-c.
[Risks and why]: Small, isolated change, but does affect non-MSE playback.
[String/UUID change made/needed]: None.
Attachment #8549129 - Flags: approval-mozilla-beta?
Attachment #8549129 - Flags: approval-mozilla-aurora?
Attachment #8549129 - Flags: approval-mozilla-beta?
Attachment #8549129 - Flags: approval-mozilla-beta+
Attachment #8549129 - Flags: approval-mozilla-aurora?
Attachment #8549129 - Flags: approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.