Closed
Bug 1121658
Opened 8 years ago
Closed 8 years ago
Remove DestroyDecodedStream() from MediaDecoder::SetDormantIfNecessary()
Categories
(Core :: Audio/Video, defect, P1)
Tracking
()
RESOLVED
FIXED
mozilla38
People
(Reporter: sotaro, Assigned: sotaro)
References
Details
Attachments
(1 file)
1.61 KB,
patch
|
roc
:
review+
Sylvestre
:
approval-mozilla-aurora+
Sylvestre
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1121064 +++ Call DestroyDecodedStream() in MediaDecoder::SetDormantIfNecessary() seem not a correct way to stop MediaStream in this situation.
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → sotaro.ikeda.g
Assignee | ||
Comment 1•8 years ago
|
||
Assignee | ||
Comment 2•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=fe2639b3b10b https://tbpl.mozilla.org/?tree=Try&rev=fe2639b3b10b
Updated•8 years ago
|
Priority: -- → P1
Assignee | ||
Comment 3•8 years ago
|
||
FYI: Diagram related to HTMLMediaElement::MozCaptureStream() https://github.com/sotaroikeda/firefox-diagrams/blob/master/media/dom_media_HTMLMediaElement_MozCaptureStream_FirefoxOS_2_2.pdf?raw=true
Assignee | ||
Updated•8 years ago
|
Attachment #8549129 -
Flags: review?(cpearce)
Assignee | ||
Updated•8 years ago
|
Comment 4•8 years ago
|
||
Comment on attachment 8549129 [details] [diff] [review] patch - Remove DestroyDecodedStream() from MediaDecoder::SetDormantIfNecessary() Review of attachment 8549129 [details] [diff] [review]: ----------------------------------------------------------------- Probably better to get Roc to check this, since it touches MediaStreams.
Attachment #8549129 -
Flags: review?(cpearce) → review?(roc)
Attachment #8549129 -
Flags: review?(roc) → review+
Assignee | ||
Comment 5•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/56824531bfec
https://hg.mozilla.org/mozilla-central/rev/56824531bfec
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
Comment 7•8 years ago
|
||
Comment on attachment 8549129 [details] [diff] [review] patch - Remove DestroyDecodedStream() from MediaDecoder::SetDormantIfNecessary() Approval Request Comment [Feature/regressing bug #]: MSE [User impact if declined]: Youtube playback can use more resources. Less consistent testing. [Describe test coverage new/current, TreeHerder]: Landed on m-c. [Risks and why]: Small, isolated change, but does affect non-MSE playback. [String/UUID change made/needed]: None.
Attachment #8549129 -
Flags: approval-mozilla-beta?
Attachment #8549129 -
Flags: approval-mozilla-aurora?
Updated•8 years ago
|
Updated•8 years ago
|
Attachment #8549129 -
Flags: approval-mozilla-beta?
Attachment #8549129 -
Flags: approval-mozilla-beta+
Attachment #8549129 -
Flags: approval-mozilla-aurora?
Attachment #8549129 -
Flags: approval-mozilla-aurora+
You need to log in
before you can comment on or make changes to this bug.
Description
•