1121658 - Remove DestroyDecodedStream() from MediaDecoder::SetDormantIfNecessary()

Status: RESOLVED FIXED

(Core :: Audio/Video, defect, P1)

Description

[Sotaro Ikeda [:sotaro]]

+++ This bug was initially created as a clone of Bug #1121064 +++

Call DestroyDecodedStream() in MediaDecoder::SetDormantIfNecessary() seem not a correct way to stop MediaStream in this situation.

Comment 1

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Remove DestroyDecodedStream() from MediaDecoder::SetDormantIfNecessary()

Comment 2

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=fe2639b3b10b
https://tbpl.mozilla.org/?tree=Try&rev=fe2639b3b10b

Comment 3

[Sotaro Ikeda [:sotaro]]

FYI: Diagram related to HTMLMediaElement::MozCaptureStream()
 https://github.com/sotaroikeda/firefox-diagrams/blob/master/media/dom_media_HTMLMediaElement_MozCaptureStream_FirefoxOS_2_2.pdf?raw=true

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8549129 [details] [diff] [review]
patch - Remove DestroyDecodedStream() from MediaDecoder::SetDormantIfNecessary()

Review of attachment 8549129 [details] [diff] [review]:
-----------------------------------------------------------------

Probably better to get Roc to check this, since it touches MediaStreams.

Comment 5

[Sotaro Ikeda [:sotaro]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/56824531bfec

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/56824531bfec

Comment 7

[Ralph Giles (:rillian)]

Comment on attachment 8549129 [details] [diff] [review]
patch - Remove DestroyDecodedStream() from MediaDecoder::SetDormantIfNecessary()

Approval Request Comment
[Feature/regressing bug #]: MSE
[User impact if declined]: Youtube playback can use more resources. Less consistent testing.
[Describe test coverage new/current, TreeHerder]: Landed on m-c.
[Risks and why]: Small, isolated change, but does affect non-MSE playback.
[String/UUID change made/needed]: None.

Comment 8

[Ralph Giles (:rillian)]

https://hg.mozilla.org/releases/mozilla-beta/rev/731843c58e0d

Comment 9

[Ralph Giles (:rillian)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/2d16e1cc65da