Closed
Bug 1121773
Opened 9 years ago
Closed 9 years ago
JavaScript Error: "uncaught exception: 2147746132" in Firefox for Android on recent fx-team
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox38.0.5 fixed, firefox39 fixed, firefox40 fixed, firefox41 fixed)
RESOLVED
FIXED
Firefox 41
People
(Reporter: nalexander, Assigned: nalexander)
References
Details
Attachments
(1 file)
1.18 KB,
patch
|
lizzard
:
approval-mozilla-aurora+
lizzard
:
approval-mozilla-beta+
Sylvestre
:
approval-mozilla-release+
|
Details | Diff | Splinter Review |
GeckoConsole(18913) [JavaScript Error: "uncaught exception: 2147746132"] at start-up and page load. Per http://james-ross.co.uk/mozilla/misc/nserror?0x80040154, this is NS_ERROR_FACTORY_NOT_REGISTERED. Interferes with the remote debugger, I think because browser.js doesn't complete loading. This is happening with @ changeset: 253669:565179dcd634 |\ tag: fx-team | | parent: 253605:f3285709bf99 | | parent: 253668:c1f6345f2803 | | user: Ryan VanderMeulen <ryanvm@gmail.com> | | date: Wed Jan 14 16:33:44 2015 -0500 | | summary: Merge m-c to fx-team. a=merge and with an earlier fx-team.
Assignee | ||
Updated•9 years ago
|
OS: Mac OS X → Android
Assignee | ||
Comment 1•9 years ago
|
||
Sorry for the noise, folks. This didn't repro on the TBPL build and was fixed by a clobber build. Sigh.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WORKSFORME
Comment 2•9 years ago
|
||
Aaron just saw this in release 37.0.1.
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
Assignee | ||
Comment 3•9 years ago
|
||
I see this in local builds all over the place, but my local builds tend to be a little non-standard so I can't be sure this is not just my issue.
Assignee | ||
Comment 4•9 years ago
|
||
Running with adb shell am start -a android.activity.MAIN -n org.mozilla.fennec_$USER/.App --es env0 NSPR_LOG_MODULES=nsComponentManager:5 I see that this is: E GeckoConsole(21263) [JavaScript Error: "uncaught exception: 2147746132"] I PRLog(21263) 1930373960[75b43100]: nsComponentManager: CreateInstanceByContractID(@mozilla.org/dom/site-specific-user-agent;1) FAILED It appears that this is a false alarm: I surmise the invocation must be at [1]. https://dxr.mozilla.org/mozilla-central/source/dom/base/Navigator.cpp#2728 I would like to understand how to catch and ignore the error rather than failing.
Assignee | ||
Comment 5•9 years ago
|
||
This is a real issue. It's fall-out from a bad patch (that I reviewed :/) from Bug 1154960. The patch conditionally included the SiteSpecificUserAgent files but didn't remove the unconditional include.
Assignee | ||
Comment 6•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/c250ce4656d0
Comment 7•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/c250ce4656d0
Assignee: nobody → nalexander
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
status-firefox41:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
Assignee | ||
Comment 8•9 years ago
|
||
Assignee | ||
Comment 9•9 years ago
|
||
Comment on attachment 8608931 [details] [diff] [review] Patch that landed on fx-team Approval Request Comment [Feature/regressing bug #]: oversight from Bug 1154960. [User impact if declined]: none; manual testing should uncover such issues. [Describe test coverage new/current, TreeHerder]: none. [Risks and why]: extremely low -- a small build system change. [String/UUID change made/needed]: none.
Attachment #8608931 -
Flags: approval-mozilla-beta?
Attachment #8608931 -
Flags: approval-mozilla-aurora?
Comment 10•9 years ago
|
||
Comment on attachment 8608931 [details] [diff] [review] Patch that landed on fx-team Approved for uplift to aurora and beta. Small fix for a regression in the remote debugger for android
Attachment #8608931 -
Flags: approval-mozilla-beta?
Attachment #8608931 -
Flags: approval-mozilla-beta+
Attachment #8608931 -
Flags: approval-mozilla-aurora?
Attachment #8608931 -
Flags: approval-mozilla-aurora+
Comment 11•9 years ago
|
||
Nick, in order to fix bug 1167208 in 38.0.5, we should uplift that to release too, right?
Flags: needinfo?(nalexander)
Comment 12•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/8c6a2ac58a5f
status-firefox40:
--- → fixed
Assignee | ||
Comment 13•9 years ago
|
||
(In reply to Sylvestre Ledru [:sylvestre] from comment #11) > Nick, in order to fix bug 1167208 in 38.0.5, we should uplift that to > release too, right? There are enough tickets that this is tricky. This patch should uplift; there is no particular patch for Bug 1167208; and this patch completes the patch from Bug 1154960, which should be uplifted. That is, the two patches https://hg.mozilla.org/mozilla-central/rev/bef3ac32b648 (original from Bug 1154960) https://hg.mozilla.org/mozilla-central/rev/c250ce4656d0 (fix from Bug 1121773) should make it all the way up to 38.0.5. (In that order.)
Flags: needinfo?(nalexander)
Comment 14•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-beta/rev/962292dc9f4f
status-firefox39:
--- → fixed
Comment 15•9 years ago
|
||
Comment on attachment 8608931 [details] [diff] [review] Patch that landed on fx-team Let's take in 38.0.5 release too. Ryan, could you land that please? Thanks
Flags: needinfo?(ryanvm)
Attachment #8608931 -
Flags: approval-mozilla-release+
Updated•9 years ago
|
status-firefox38.0.5:
--- → affected
Comment 16•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-release/rev/5f203231528e
Flags: needinfo?(ryanvm)
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•