1121866 - [Loop] No error message shown when trying to join to an expired room

Status: RESOLVED INVALID

(Firefox OS Graveyard :: Gaia::Loop, defect)

Description

[isabelrios]

Flame 2.0
Gecko-5f9dc54
Gaia-31d6c94
Loop master version
User A logged in mobile loop app

STR
1. User A creates a room
2. Change the date of the device so the room appears as expired in Room details
3. Tap on the room name to join

EXPECTED
An error message should be shown: Oops... You can't join because the room has expired. Do you want to delete it?

ACTUAL
When user taps on the room the communication window is open, with the message that he is the only user in the room. I have waited for a while, but nothing else happens.

Comment 1

[José Antonio Olivera Ortega [:jaoo]]

Attachment: Pointer to Github PR https://github.com/mozilla-b2g/firefoxos-loop-client/pull/454

Comment 2

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 8549545 [details] [review]
Pointer to Github PR https://github.com/mozilla-b2g/firefoxos-loop-client/pull/454

Cristian, something like the code in the patch would do the trick. Would you mind to give us some feedback? Thanks!

Comment 3

[Cristian Rodriguez (:crdlc)]

Comment on attachment 8549545 [details] [review]
Pointer to Github PR https://github.com/mozilla-b2g/firefoxos-loop-client/pull/454

LGTM, thanks a lot

Comment 4

[Maria Angeles Oteo (:oteo)]

The STR of this bug describes the correct behavior, as the Room is not really expired (it's still alive in the Server)and it's perfectly accessible so the actual Result is the correct one so closing the bug as Invalid.

What it was not correct, it's that in Room Details, the Room appears as Expired when it's not.

This issue has been fixed by Jose Antonio in bug 1121924