1121996 - [Loop] Expired rooms are not shown accordingly in room list

Status: RESOLVED INVALID

(Firefox OS Graveyard :: Gaia::Loop, defect)

Description

[isabelrios]

Flame 2.0
Gecko-5f9dc54
Gaia-31d6c94
Loop master build

User A logged in mobile loop app
User A has created a room

1. Room created by A has expired
2. Tap on the room to try to join
3. Check room list

EXPECTED
Below the name of the room it should appear a label indicating: Expired

ACTUAL
There is nothing in room list indicating whether a room has expired or not

Comment 1

[Cristian Rodriguez (:crdlc)]

This is because of the room has not expired actually thought. Are you assuming that the room expired changing the local date/time in your device? Rooms expire in 8 weeks. Maybe we have to show the expired date in detail checking the remote date to avoid the confusion

Comment 2

[isabelrios]

I am assuming that the room expired when the date changed to a future date (more than 8 weeks), because in room details I can see Expired. And, it is not possible to join to that room, although as reported in bug 1121866 the error is not the one thought to be shown when a room has expired.

Comment 3

[Cristian Rodriguez (:crdlc)]

But really you cannot expire a room because it is done remotely. Changing the local time you can see Expired in detail although it is not true. BTW there are two issues here:

1) Show the Expires date in detail based on remote date and no local like current implementation. Users can say that they live ten years a head but this does not mean that the room has been expired because this is controlled by the server like whatsapp for instance.

2) Obviously we have other problem because you couldn't join the room which was not really expired thought

Jose, some idea about second point?

Comment 4

[Cristian Rodriguez (:crdlc)]

BTW this bug should be closed because after talking about this one week ago with Maria Angeles and Monica we took the decision of getting rid of the "Expired" label from call log. Except when users try to join a room that was deleted remotely by owner or expired where the label "No longer available" will be displayed. More details bug 1120131

Comment 5

[Maria Angeles Oteo (:oteo)]

Isabel, I am testing your STR, creating a room and later changing the device time so the Room appears "expired" in the Room detail. Two things to comment:

1)As Cristian has commented, although in the Room details say that the room is expired. Really it's not, and the Room should be available. I can join without problem, please let me know if I am missing some steps (Removing the ni to Jose Antonio until we can confirm the STR). In case it happens we should open another bug.

2)Showing "Expired" string in the Room list, that's something we decided not including it after analyzing the last visual proposed by Pau. The string "Expired" or "Not longer available" (that's the definitive string) only will be shown in case you try to join a Room that is really expired. So checking the state of that Room with the Server, it answer us with the corresponding error and, only in that case, the string is painted in the Room list.

So according to the bug title and the description, if this bug is about showing "Expired" string in the Room list without user's action that's something that it's not going to happen, so I propose closing this bug as invalid. Isael, let me know what you think.

Regarding the time trips (when changing the device date) and the wrong expired dates in Room detail, in that case that's something we need to align and agree with Product and UX. I'll update the conclusions about what will implement for 1.1.1 version in bug 1121866.

Thanks a lot Isabel!

Comment 6

[isabelrios]

Hi Maria,

1) Ok, understood! And I will check carefully the behavior and open a bug in case I can reproduce the problem when trying to join

2) Ok, I already saw the change in the string, sorry about that!

I agree with closing this bug as invalid and in case I can reproduce what described in 1) I will file a new one. 

Thanks!