Closed Bug 1121947 Opened 5 years ago Closed 4 years ago
[E10s] Ensure that drop effect is updated properly on OSX
With the latest patch for bug 936092 drop effect works properly on Linux only.
indeed, I can't run http://www.wavesurfer.fm/example/split-channels/ with e10s on OSX. Works fine in non e10s windows.
Actually, I'll just take this m7.
Assignee: nobody → mconley
This mostly works.
Assignee: jmathies → enndeakin
Status: NEW → ASSIGNED
thanks for picking these up.
Don't we end up using old drag action? On linux we explicitly wait for the child process to tell when to update the OS level drag effect. Do we not have anything like that on OSX? I'd expect there to be some Cocoa specific implementation of UpdateDragEffect()
There isn't a function like that on Mac or Windows. You're expected to return the desired effect from the dragover handler so this needs to synchronous. (On Mac, this is draggingUpdated) The best we can do here I think is to return the effect that the child set previously.
Ok, that is what I feared. I wonder what other browsers do here.
Comment on attachment 8614167 [details] [diff] [review] Updated patch "will take of setting this." will take care of setting this. I don't have then better ideas for this. I'll ask around what blink does here. We can improve the setup if something better is found.
Attachment #8614167 - Flags: review?(bugs) → review+
https://code.google.com/p/chromium/codesearch#chromium/src/content/browser/web_contents/web_drag_dest_mac.mm&q=NSDragOperation&sq=package:chromium&dr=C&l=79 hints that blink is actually doing something similar
You need to log in before you can comment on or make changes to this bug.