1121947 - [E10s] Ensure that drop effect is updated properly on OSX

Status: RESOLVED FIXED

(Core :: DOM: Copy & Paste and Drag & Drop, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

With the latest patch for bug 936092 drop effect works properly on Linux only.

Comment 1

[(not reading bugmail) Nick Desaulniers [:\n]]

indeed, I can't run http://www.wavesurfer.fm/example/split-channels/ with e10s on OSX.  Works fine in non e10s windows.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Actually, I'll just take this m7.

Comment 3

[Neil Deakin]

Attachment: Drag feedback on Mac

This mostly works.

Comment 4

[Neil Deakin]

Attachment: Updated patch

Comment 5

[Jim Mathies [:jimm]]

thanks for picking these up.

Comment 6

[Neil Deakin]

Attachment: Testcase

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Don't we end up using old drag action? On linux we explicitly wait for the child process to tell when to update the OS level drag effect. Do we not have anything like that on OSX?
I'd expect there to be some Cocoa specific implementation of UpdateDragEffect()

Comment 8

[Neil Deakin]

There isn't a function like that on Mac or Windows. You're expected to return the desired effect from the dragover handler so this needs to synchronous. (On Mac, this is draggingUpdated) The best we can do here I think is to return the effect that the child set previously.

Comment 9

[Olli Pettay [:smaug][[e-mail]]]

Ok, that is what I feared. I wonder what other browsers do here.

Comment 10

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8614167 [details] [diff] [review]
Updated patch

"will take of setting this."
will take care of setting this.


I don't have then better ideas for this. I'll ask around what blink does here.
We can improve the setup if something better is found.

Comment 11

[Olli Pettay [:smaug][[e-mail]]]

https://code.google.com/p/chromium/codesearch#chromium/src/content/browser/web_contents/web_drag_dest_mac.mm&q=NSDragOperation&sq=package:chromium&dr=C&l=79 hints that blink is actually doing something similar

Comment 12

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f48df2d19520

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f48df2d19520