Closed Bug 1121947 Opened 5 years ago Closed 4 years ago

[E10s] Ensure that drop effect is updated properly on OSX

Categories

(Core :: Drag and Drop, defect)

36 Branch
x86_64
macOS
defect
Not set
Points:
3

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
e10s m7+ ---
firefox41 --- fixed

People

(Reporter: smaug, Assigned: enndeakin)

References

Details

Attachments

(2 files, 1 obsolete file)

With the latest patch for bug 936092 drop effect works properly on Linux only.
Blocks: 936092
No longer depends on: 1121946
No longer blocks: 936092
Depends on: 936092
indeed, I can't run http://www.wavesurfer.fm/example/split-channels/ with e10s on OSX.  Works fine in non e10s windows.
OS: Linux → Mac OS X
Flags: needinfo?(mconley)
Actually, I'll just take this m7.
Assignee: nobody → mconley
Flags: needinfo?(mconley)
Assignee: mconley → jmathies
Attached patch Drag feedback on Mac (obsolete) — Splinter Review
This mostly works.
Assignee: jmathies → enndeakin
Status: NEW → ASSIGNED
Attached patch Updated patchSplinter Review
Attachment #8614005 - Attachment is obsolete: true
Attachment #8614167 - Flags: review?(bugs)
thanks for picking these up.
Attached file Testcase
Blocks: 1121946
Points: --- → 3
Don't we end up using old drag action? On linux we explicitly wait for the child process to tell when to update the OS level drag effect. Do we not have anything like that on OSX?
I'd expect there to be some Cocoa specific implementation of UpdateDragEffect()
There isn't a function like that on Mac or Windows. You're expected to return the desired effect from the dragover handler so this needs to synchronous. (On Mac, this is draggingUpdated) The best we can do here I think is to return the effect that the child set previously.
Ok, that is what I feared. I wonder what other browsers do here.
Comment on attachment 8614167 [details] [diff] [review]
Updated patch

"will take of setting this."
will take care of setting this.


I don't have then better ideas for this. I'll ask around what blink does here.
We can improve the setup if something better is found.
Attachment #8614167 - Flags: review?(bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/f48df2d19520
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Depends on: 1256162
You need to log in before you can comment on or make changes to this bug.