1121994 - Implement adopted callback for custom elements

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P3)

Description

[Gabor Krizsanits (INACTIVE)]

The spec does not mention this callback yet, but there were numerous talks where everybody agreed that we need this callback.

Comment 1

[Gabor Krizsanits (INACTIVE)]

Do you think this callback could end up in the spec soonish? Is there any disagreement about it? Do we know exactly when it should be called? (I'm just trying to decide when would it make sense to start working on this)

Comment 2

[Anne (:annevk)]

I think there's still disagreement about whether callbacks should have symbols as names or not. If not, I would expect "adoptedCallback" that is passed the old and new document.

Comment 3

[Edgar Chen [:edgar]]

Mark this bug as a duplicate of bug 1293921 since we plan to implement all lifecycle callback in bug 1293921.

Comment 4

[Edgar Chen [:edgar]]

On a second thought, we decide splitting bug 1293921 into smaller pieces, so re-open this bug for implementing adoptedCallback.

Comment 5

[John Dai[:jdai]]

Attachment: patch, v1

Follow the spec[1] implements adopted callback for custom elements. I only tested on my local, hence, could you give me some feedback about this patch? Thank you.

[1] https://dom.spec.whatwg.org/#concept-node-adopt

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8905947 [details] [diff] [review]
patch, v1


>+++ b/dom/base/CustomElementRegistry.h
>@@ -35,41 +35,55 @@ class Promise;
> struct LifecycleCallbackArgs
> {
>   nsString name;
>   nsString oldValue;
>   nsString newValue;
>   nsString namespaceURI;
> };
> 
>+struct LifecycleAdoptedCallbackArgs
>+{
>+  nsIDocument* oldDocument;
>+  nsIDocument* newDocument;
>+};
I think these both should be nsCOMPtr<nsIDocument>. And normal coding style would be to
call them mOldDocument and mNewDocument, but I see the previous struct doesn't use that either, so naming is up to you.

Comment 7

[John Dai[:jdai]]

Attachment: patch, v2

Rebase and carry r+.

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=efa3e65f823ca2adce00b974fa25b6d8889aa34c&filter-tier=1&group_state=expanded

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0ad5ea4a3f1c
Implement adopted callback for custom elements. r=smaug

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/0ad5ea4a3f1c