Closed
Bug 1122357
Opened 10 years ago
Closed 10 years ago
Remove [Pure] for MozNFCTag.id
Categories
(Firefox OS Graveyard :: NFC, defect)
Tracking
(firefox36 wontfix, firefox37 wontfix, firefox38 fixed, b2g-v2.2 fixed, b2g-master fixed)
RESOLVED
FIXED
2.2 S4 (23jan)
People
(Reporter: allstars.chh, Assigned: allstars.chh)
References
Details
Attachments
(1 file)
1014 bytes,
patch
|
bzbarsky
:
review+
bajaj
:
approval-mozilla-b2g37+
|
Details | Diff | Splinter Review |
Pure is not required for MozNFCTag.id
See https://bugzilla.mozilla.org/show_bug.cgi?id=1115465#c11
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8550040 -
Flags: review?(bugs)
![]() |
||
Comment 2•10 years ago
|
||
Comment on attachment 8550040 [details] [diff] [review]
Patch.
r=me
Attachment #8550040 -
Flags: review?(bugs) → review+
![]() |
||
Comment 3•10 years ago
|
||
This was blocking me, so I took the liberty of landing it:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0640a60fdba5
Comment 4•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 5•10 years ago
|
||
Comment on attachment 8550040 [details] [diff] [review]
Patch.
[Approval Request Comment]
Bug caused by (feature/regressing bug #):
Bug 1115465
User impact if declined:
Wrong usage of WebIDL bindings, could possibly affect JS Engine performance.
And given that we discovered this problem quite early, I'd like to uplift this to avoid future problems.
Testing completed:
Manually.
Risk to taking this patch (and alternatives if risky):
No.
String or UUID changes made by this patch:
No.
Attachment #8550040 -
Flags: approval-mozilla-b2g37?
Updated•10 years ago
|
Attachment #8550040 -
Flags: approval-mozilla-b2g37? → approval-mozilla-b2g37+
Comment 6•10 years ago
|
||
status-b2g-v2.2:
--- → fixed
status-b2g-master:
--- → fixed
status-firefox36:
--- → wontfix
status-firefox37:
--- → wontfix
status-firefox38:
--- → fixed
Target Milestone: --- → 2.2 S4 (23jan)
You need to log in
before you can comment on or make changes to this bug.
Description
•