Closed
Bug 1122432
Opened 10 years ago
Closed 10 years ago
[Stingray] UI-Transition - Banner
Categories
(Firefox OS Graveyard :: Gaia, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: suchiu, Assigned: suchiu)
References
Details
Attachments
(2 files)
Animation of expanding the banner
|
Assignee | |
Comment 1•10 years ago
|
||
Please review this video for toast banner UI
|
|
Assignee | |
Comment 2•10 years ago
|
||
1. Add fly-up and hiding state on smart-banner
2. Modify interactive notification to fit the change of smart-banner
3. Fix the bug happens when we trigger notifications multiple times during hiding stage in hideNotification function
Attachment #8556960 -
Flags: review?(im)
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8556960 [details] [review]
Pull Request
The patch looks good to me. But the animation may have an unexpected shaking behavior. Please check this with visual.
Attachment #8556960 -
Flags: review?(im) → review+
|
|
||
Comment 4•10 years ago
|
||
merged to master:
https://github.com/mozilla-b2g/gaia/commit/c3f61c4652252d5bf15069d4f2f8ac42c868422f
gaia try is all green:
https://treeherder.mozilla.org/#/jobs?repo=gaia-try&revision=39a62e80752e
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•