1122609 - execute_script() called with new_sandbox=False in chrome context does not use current script_args but those from a former call

Status: RESOLVED FIXED

(Testing :: Marionette Client and Harness, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

When you call execute_script with new_sandbox=False it will operate on a wrong list of arguments:

        retval = self.marionette.execute_script("""
          return arguments[0];
        """, script_args=['test1'])
        self.assertEqual(retval, "test1")  # pass

        retval = self.marionette.execute_script("""
          return arguments[0];
        """, script_args=["test2"])
        self.assertEqual(retval, "test2")  # pass

        retval = self.marionette.execute_script("""
          return arguments[0];
        """, script_args=["test3"], new_sandbox=False)
        self.assertEqual(retval, "test3")  # fail

Here the 3rd block fails because arguments in the sandbox is equal to the one from the 2nd block. Looks like we even try to re-use the arguments instead of pushing in the new ones.

Comment 1

[Chris Manchester (limited bugmail, email directly)]

Arguments are set as a property of the sandbox at the time of sandbox creation in chrome scope, not so for content.

Comment 2

[Chris Manchester (limited bugmail, email directly)]

This looks ok locally:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4335bde402b4
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ea79d810382e

Comment 3

[Chris Manchester (limited bugmail, email directly)]

Try with more coverage, still looks good:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=96688345b897&exclusion_state=all

Comment 4

[Chris Manchester (limited bugmail, email directly)]

Attachment: MozReview Request: bz://1122609/chmanchester

Comment 5

[Chris Manchester (limited bugmail, email directly)]

/r/2687 - Bug 1122609 - Test that setting script_args for multiple execute_script calls in chrome scope works when the sanbox is reused.
/r/2689 - Bug 1122609 - Set marionette arguments per execute script call in chrome scope even if the sanbox is reused.

Pull down these commits:

hg pull review -r 75859fa90d7f32359f17c807cd2cda00555596a3

Comment 6

[Jonathan Griffin (:jgriffin)]

https://reviewboard.mozilla.org/r/2685/#review1901

lgtm, thanks!

Comment 7

[Chris Manchester (limited bugmail, email directly)]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/8f41739aee27
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/ffa9eece8287

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8f41739aee27
https://hg.mozilla.org/mozilla-central/rev/ffa9eece8287

Comment 10

[Chris Manchester (limited bugmail, email directly)]

Attachment: MozReview Request: Bug 1122609 - Set marionette arguments per execute script call in chrome scope even if the sanbox is reused.

Comment 11

[Chris Manchester (limited bugmail, email directly)]

Attachment: MozReview Request: Bug 1122609 - Test that setting script_args for multiple execute_script calls in chrome scope works when the sanbox is reused.

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Moving bugs for Marionette client due to component changes.