1122688 - [Privacy Panel][Transparency Control] EmergencyCall has a missing icon in the Application list under Transparency Control.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Martin Shuman [:Marty]]

Attachment: EmergencyCall_Missing_Icon_Screenshot.png

Description:
EmergencyCall in Privacy Panel under Transparency Control > Applications has a missing icon in the list view.

Notes:
-If EmergencyCall is the first item viewed from this list, the icon will appear broken.
-If EmergencyCall is viewed after another item from the list, the user will see the icon from the previously viewed application.
   
Repro Steps:
1) Update a Flame device to BuildID: 20150116010205
2) Launch the Settings app and open the Privacy Panel
3) Select Transparency Control
4) Select Applications
5) Scroll down to view EmergencyCall
  
Actual:
EmergencyCall is missing an icon.
  
Expected: 
EmergencyCall is not missing an icon.
  
Environmental Variables:
Device: Flame 3.0 Master (Full Flash) (319MB)
BuildID: 20150116010205
Gaia: 401e981f51cf047292d101c785be8ec48bf75e8c
Gecko: cac6192956ab
Gonk: a814b2e2dfdda7140cb3a357617dc4fbb1435e76
Version: 38.0a1 (3.0 Master)
Firmware: V18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0
  
Repro frequency: 4/4
See attached: screenshot, logcat

-------------------------------------------

This issue does NOT occur on Flame 2.2
The Transparency Control menus are not currently in the Privacy Panel in this branch.

Environmental Variables:
Device: Flame 2.2
BuildID: 20150116002502
Gaia: 2f916cdba7305b51a72482b6bfe860c5b8924f9c
Gecko: b4c7c83a44a5
Gonk: a814b2e2dfdda7140cb3a357617dc4fbb1435e76
Version: 37.0a2 (2.2)
Firmware: V18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

-------------------------------------------

This issue does NOT occur on Flame 2.1
Privacy Panel was not implemented on this branch.

Environmental Variables:
Device: Flame 2.1
BuildID: 20150116001340
Gaia: 230a9c5303e2113f7dbcaf431441ae2138853141
Gecko: e43e97795f5d
Gonk: a814b2e2dfdda7140cb3a357617dc4fbb1435e76
Version: 34.0 (2.1)
Firmware: V18D-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Comment 1

[Martin Shuman [:Marty]]

Attachment: logcat-Privacy-Transparency-EmergencyCall.txt

Comment 2

[KTucker [:KTucker][Inactive 3/4/2016]]

Seems minor so not nominating to block on this.

Comment 3

[Peter Bylenga [:PBylenga]]

NI on component owner for assignment.

Comment 4

[Gerry Chang [:gchang]]

NI developer for more information about the missing icon.

Comment 5

[Arthur Chen [:arthurcc][inactive after 6/30]]

Marta, could you help check this? Thanks.

Comment 6

[marta]

It will be fixed later this week by :kaze.

Comment 7

[FxOS EPM team]

Dear Fabien,
Do you have any update for this bug? Thanks!

Comment 8

[Josh Cheng [:josh]]

Hi Marta,
Do you know whether :kaze have any progress on the bug?
Thanks!

Comment 9

[Fabien Cazenave [:kaze]]

I pinged Marta about this bug a few days ago but unfortunately she’s on holiday…

There must have been a misunderstanding: I’m not working on this. I’ve been working on other icon-related issues for the Privacy Panel, but not this one. I think this bug is more general and affects other parts of Gaia, e.g. if you install Twitter its icon is also broken in the Settings “App Permissions” panel. I bet the Emergency Call icon would be missing too if this app was listed in the “App Permissions” panel.

I’ll have a look at this tomorrow. If I can come up with a patch, who could review it quickly before the upcoming freeze?

Comment 10

[GitHub Autolander Bot]

Attachment: [gaia] fabi1cazenave:emergencyCallIcon > mozilla-b2g:master

Comment 11

[Fabien Cazenave [:kaze]]

Attachment: pull request

For the particular case of “Emergency Call”, it turns out the icon path that is specified in the manifest is incorrect: it points to /styles/icons/Blank.png, but there’s no Blank.png. Here’s a quick fix, adding a blank icon.

If we have a better icon for this app, I’ll update my PR right away.

Comment 12

[Julien Wajsberg [:julienw]]

Comment on attachment 8566591 [details] [review]
pull request

I don't know, but Doug should.

Comment 13

[Doug Sherk (:drs) (inactive)]

Comment on attachment 8566591 [details] [review]
pull request

IMO, we should re-use the Dialer icon, as we currently do for the Callscreen app.

Comment 14

[Fabien Cazenave [:kaze]]

Comment on attachment 8566591 [details] [review]
pull request

Thanks for the feedback Doug, here’s an updated patch.

Comment 15

[Fabien Cazenave [:kaze]]

Merged on master: https://github.com/mozilla-b2g/gaia/commit/a290cd2

Comment 16

[Fabien Cazenave [:kaze]]

Comment on attachment 8566591 [details] [review]
pull request

[Approval Request Comment]
[User impact] if declined: broken icon in the Privacy Panel
[Testing completed]: manual
[Risk to taking this patch] (and alternatives if risky): none
[String changes made]: none

Comment 17

[Ryan VanderMeulen [:RyanVM]]

Please remember to resolve bugs when you land on master. Failing to do so can and will result in delays getting your patches uplifted.

v2.2: https://github.com/mozilla-b2g/gaia/commit/ef95de26db918e8851f6067068666d619426a699

Comment 18

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

This issue is verified fixed for the latest Nightly 3.0 and 2.2 builds.

Actual Results: Emergency call has the same icon as the Callscreen app.
	
Environmental Variables:
Device: Flame 3.0 KK (319 MB) (Full Flash)
BuildID: 20150304010324
Gaia: 3fc0ac309f5fb0c1fe82c12223b955a4efce27e6
Gecko: c5b90c003be8
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 39.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0

Environmental Variables:
Device: Flame 2.2 KK (319 MB) (Full Flash)
BuildID: 20150304002529
Gaia: 8b4b3e4b7e7c308764f71542437fd60625ac6b75
Gecko: 2cb52b7cda5a
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0