Closed
Bug 1123072
Opened 11 years ago
Closed 11 years ago
[Flatfish] build broken due to unused variables in GonkGPSGeolocationProvider.cpp
Categories
(Core :: DOM: Geolocation, defect)
Tracking
()
RESOLVED
FIXED
mozilla38
People
(Reporter: gerard-majax, Assigned: gerard-majax)
References
Details
(Whiteboard: [systemsfe])
Attachments
(1 file, 4 obsolete files)
|
1.78 KB,
patch
|
gerard-majax
:
review+
|
Details | Diff | Splinter Review |
In file included from Unified_cpp_dom_system_gonk0.cpp:38:0:
../../../../gecko/dom/system/gonk/GonkGPSGeolocationProvider.cpp: In member function 'void GonkGPSGeolocationProvider::StartGPS()':
../../../../gecko/dom/system/gonk/GonkGPSGeolocationProvider.cpp:676:8: error: unused variable 'singleShot' [-Werror=unused-variable]
bool singleShot = false;
^
In file included from Unified_cpp_dom_system_gonk0.cpp:38:0:
../../../../gecko/dom/system/gonk/GonkGPSGeolocationProvider.cpp: At global scope:
../../../../gecko/dom/system/gonk/GonkGPSGeolocationProvider.cpp:60:20: error: 'kNetworkConnStateChangedTopic' defined but not used [-Werror=unused-variable]
static const char* kNetworkConnStateChangedTopic = "network-connection-state-changed";
|
Assignee | |
Comment 1•11 years ago
|
||
|
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → lissyx+mozillians
Whiteboard: [systemsfe]
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8550903 -
Flags: review?(kchen)
|
||
Updated•11 years ago
|
Attachment #8550903 -
Flags: review?(kchen) → review+
|
|
Assignee | |
Comment 2•11 years ago
|
||
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
||
Comment 3•11 years ago
|
||
this failed to apply:
renamed 1123072 -> Bug-1123072---Fix-build-of-GonkGPSGeolocationProvi.patch
applying Bug-1123072---Fix-build-of-GonkGPSGeolocationProvi.patch
patching file dom/system/gonk/GonkGPSGeolocationProvider.cpp
Hunk #1 FAILED at 51
1 out of 2 hunks FAILED -- saving rejects to file dom/system/gonk/GonkGPSGeolocationProvider.cpp.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working dir
errors during apply, please fix and refresh Bug-1123072---Fix-build-of-GonkGPSGeolocationProvi.patch
could you take a look, thanks!
Flags: needinfo?(lissyx+mozillians)
Keywords: checkin-needed
|
|
Assignee | |
Comment 4•11 years ago
|
||
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8550903 -
Attachment is obsolete: true
Flags: needinfo?(lissyx+mozillians)
|
|
Assignee | |
Comment 5•11 years ago
|
||
Comment on attachment 8551172 [details] [diff] [review]
Fix build of GonkGPSGeolocationProvider on Flatfish r=kchen
Carrying r+, rebased on master
Tomcat, can you retry with this one?
Flags: needinfo?(cbook)
Attachment #8551172 -
Flags: review+
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
|
||
Comment 6•11 years ago
|
||
Flags: needinfo?(cbook)
|
|
Assignee | |
Comment 7•11 years ago
|
||
This is the diff from the try push.
Attachment #8551189 -
Attachment is obsolete: true
Flags: needinfo?(cbook)
|
|
Assignee | |
Comment 8•11 years ago
|
||
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8551199 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8551172 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 9•11 years ago
|
||
|
|
Assignee | |
Comment 10•11 years ago
|
||
Comment on attachment 8551203 [details] [diff] [review]
Fix build of GonkGPSGeolocationProvider on Flatfish r=kchen
Carrying r+, rebased on top of bug 878748
Attachment #8551203 -
Flags: review+
|
|
||
Comment 11•11 years ago
|
||
Keywords: checkin-needed
|
||
Comment 12•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
|
|
||
Updated•11 years ago
|
Flags: needinfo?(cbook)
You need to log in
before you can comment on or make changes to this bug.
Description
•