1121907 - [flatfish] Fix build break by Werrors in flatfish

Status: RESOLVED DUPLICATE of bug 1123072

(Firefox OS Graveyard :: General, defect)

Description

[Danny Liang [:dliang]]

There are some build breaks by enable Werror in flatfish, create this bug for tracking.

Comment 1

[Danny Liang [:dliang]]

Attachment: wip_for_Werror.patch

Attachment is the patch to avoid build break by Werror

Comment 2

[Juan Gomez [:_AtilA_] (CET/CEST)]

Hi Danny,
I started to work in bug 1122932 because of the build errors. Some of them can be fixed by just upgrading the toolchain to a newer one, and other would need a little more work. My plan is ti migrate the toolchain first and fix the remaining errors later.

If you are ok with it, I can take this bug too.

Comment 3

[Juan Gomez [:_AtilA_] (CET/CEST)]

Attachment: 0001-Bug-1121907-Fix-build-errors-with-warnings-as-errors.patch

Comment 4

[Danny Liang [:dliang]]

(In reply to Juan Gomez [:_AtilA_] (UTC+0) from comment #2)
> Hi Danny,
> I started to work in bug 1122932 because of the build errors. Some of them
> can be fixed by just upgrading the toolchain to a newer one, and other would
> need a little more work. My plan is ti migrate the toolchain first and fix
> the remaining errors later.
> 
> If you are ok with it, I can take this bug too.

Sounds great, I also suspect some build errors are caused by toolchain. I am happy if you can help on this. Thank you very much.

Comment 5

[(no longer active)]

Comment on attachment 8550956 [details] [diff] [review]
0001-Bug-1121907-Fix-build-errors-with-warnings-as-errors.patch

Review of attachment 8550956 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/bluetooth/bluedroid/BluetoothHALHelpers.h
@@ +201,1 @@
>      CONVERT(BT_PROPERTY_REMOTE_RSSI, PROPERTY_REMOTE_RSSI),

Instead of repeating this twice, please remove the comma from this line, move the #if to the next line and add the comma before the next CONVERT.  Then you can get rid of the #else.

Comment 6

[Juan Gomez [:_AtilA_] (CET/CEST)]

Attachment: 0001-Bug-1121907-Fix-build-errors-with-warnings-as-errors.patch