1123143 - Make Bugzilla link to MozReview link directly to diff instead of review request page.

Status: RESOLVED FIXED

(bugzilla.mozilla.org Graveyard :: Extensions: MozReview Integration, defect, P1)

Description

[Mike Conley (:mconley) (:⚙️)]

For the most part, when reviewers go to MozReview, they want to look at the code, and not previous reviews.

The link in MozReview should link them directly to the diff viewer page of the squashed review request instead, where they can immediately start making comments. Because we now show the commit list in the diff page, this means they can navigate to child commit diffs easily as well.

Comment 1

[Steven MacLeod [:smacleod]]

If we want to encourage people to review at the commit level, rather than always just commenting on the giant folded view, maybe linking directly to the folded diff isn't the best call? Maybe use the first commits diff?

Maybe linking to the folded diff is fine and we just need to educate about the different diff views better?

Comment 2

[Mark Côté [:mcote]]

The new MozReview Bugzilla table could also add an extra link to the diff.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

I won't claim to be necessarily representative of your entire user base, but my most frequent use case for "clicking on a patch link in a bug" is "stalking someone else's patch", where I am not a reviewer. Sometimes that leads to me wanting to leave some review comments, but that's rare.

So while I think optimizing the "review a patch" flow is great, it shouldn't come at the cost of significantly hampering the "just see the patch" use case. It sounds like the proposed solution to this bug would probably strike a better balance.

Comment 5

[Mark Côté [:mcote]]

Attachment: Add commit IDs as links to diffs

This adds commit IDs that function as links to the review-request diffs to the child summaries, similar to how the summary tables look in MozReview right now.

Comment 6

[:glob ✱]

Comment on attachment 8632618 [details] [diff] [review]
Add commit IDs as links to diffs

Review of attachment 8632618 [details] [diff] [review]:
-----------------------------------------------------------------

r=glob

::: extensions/MozReview/web/js/mozreview.js
@@ +34,4 @@
>  
>          if (!isParent) {
>              tdSummary.addClass('mozreview-child-request-summary');
> +            diffLink.attr('href', rrDiffUrl(rr.id)); 

remove trailing whitespace

Comment 7

[Mark Côté [:mcote]]

To ssh://[e-mail]/webtools/bmo/bugzilla.git
   de34aed..e4c6417  master -> master