1123378 - [Loop] Remote room participant name is not shown correctly for room url clickers

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Loop, defect)

Description

[José Antonio Olivera Ortega [:jaoo]]

Preconditions:

User B stores User A's contact on the contact app.

STR:

1.- User A logs into Fx Hello on desktop.
2.- User B logs into Fx Hello on Fx OS.
3.- User A creates a room shares the room link with user B.
4.- User B clicks on the link and joins the room.
5.- User A joins the room as well.

Expected result:

User A's contact name should be shown in the room conversation UI in User B's device.

Actual result

'Guest' is shown as User A's contact name.

Comment 1

[Maria Angeles Oteo (:oteo)]

Jose Antonio, following your STR I am not completely sure if Desktop User A joins the Room via Firefox Browser Hello app or it opens the Room URL via a Firefox tab.

Just F.Y.I, and according Mark's feedback in bug 1121861, the behavior should be this for each case

 - If a Room URL is open in a Firefox tab, guest is always used (even if the user is logged in Firefox Browser Hello App).
 - If a Room URL is open via Firefox Browser Hello app the identity used for login in will be used (or guest if user has not logged in)

Comment 2

[José Antonio Olivera Ortega [:jaoo]]

Attachment: Pointer to Github PR https://github.com/mozilla-b2g/firefoxos-loop-client/pull/480

Comment 3

[José Antonio Olivera Ortega [:jaoo]]

(In reply to Maria Angeles Oteo (:oteo) from comment #1)
> Jose Antonio, following your STR I am not completely sure if Desktop User A
> joins the Room via Firefox Browser Hello app or it opens the Room URL via a
> Firefox tab.

User A logs into Fx Hello on desktop (let's say the app) and create a new room (e.g. 'Conversation 1'). User A joins the room by clicking on the entry for 'Conversation 1' in the room list.

>  - If a Room URL is open via Firefox Browser Hello app the identity used for
> login in will be used (or guest if user has not logged in)

That's the case. The identity we show in that case is 'Guest' too (that's the bug we will fix here).

Hope it clarifies the scenario.

Comment 4

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 8551661 [details] [review]
Pointer to Github PR https://github.com/mozilla-b2g/firefoxos-loop-client/pull/480

Cristian, would you mind to review this pull request please? Thanks!

Comment 5

[Cristian Rodriguez (:crdlc)]

Comment on attachment 8551661 [details] [review]
Pointer to Github PR https://github.com/mozilla-b2g/firefoxos-loop-client/pull/480

LGTM, left a couple of comments just in case you consider them interesting

Comment 6

[José Antonio Olivera Ortega [:jaoo]]

Landed on master branch at:

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/607532d3765f85e0e118163e8581a8b51804886d