1123519 - [ReadingList] Allow adding items to the Reading List via the sidebar

Status: RESOLVED INCOMPLETE

(Firefox Graveyard :: Reading List, defect, P2)

Description

[Blair McBride [:Unfocused] (UNAVAILABLE)]

We want to be able to add items to the Reading List via the sidebar UI.

Undetermined as-yet whether this should only be the current tab, or it should prompt for a URL.

Comment 1

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Micheal: Do we want to prompt for a URL here? If so, could you mock that up?

Comment 2

[Michael Maslaney [:mmaslaney] ([e-mail])]

A URL prompt seems appropriate for the URL "Add to Reading List" button, but not the sidebar. Bit of a disconnect

Comment 3

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Clarified this on IRC: Button will just add the current tab's URL. Same with the button in the URLBar.

So that keeps v1 nice and simple. We'll look into the possibility of adding arbitrary URLs (not loaded in a tab) in v2+.

Comment 4

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Sorting out strings... Michael, can you confirm?

Button label: "Add to Reading List"
Button tooltip: "Add this page to your Reading List"

(The bookmarks star button's tooltip is "Bookmark this page")

Comment 5

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Oh, I guess there's also some overlap here with bug 1131461 and https://projects.invisionapp.com/share/NK1ZBQ6SY#/screens/59725441

Although, given the sidebar isn't so obviously associated with the current tab, I'm not sure using the same exact wording is best.

Comment 6

[Michael Maslaney [:mmaslaney] ([e-mail])]

+1

Comment 7

[Marco Mucci [:MarcoM]]

Not required for Reading List V1 Campaign Release.

Comment 8

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Mass change of ReadingList bugs, moving to their own component. Filter bugspam on the following quote:

“Reading is to the mind what exercise is to the body.”
― Joseph Addison

Comment 9

[Justin Dolske [:Dolske]]

P2 based on this being a compromise for A11Y with the URL bar "add to RL" button, which has some A11Y issues.

Comment 10

[Florian Quèze [:florian]]

ReadingList is no longer our priority.