1123579 - Search Widget preview for the Beta channel has the icon from the release channel

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Search Activity, defect)

Description

[Flaviu Cos]

Attachment: Search Widget preview.jpg

Environment: 
Device: Asus Transformer TF101 (Android 4.0.3);
Build: 36 Beta 1;

Steps to reproduce:
1. Go to widgets;
2. Observe the Search Widget preview for the Beta channel.

Expected results:
Search Widget preview for the Beta channel have the correct branding.

Actual results:
Search Widget preview for the Beta channel has the icon from the release channel.

Notes: Please see the attachment.

Comment 1

[:Margaret Leibovic]

We purposefully decided to do this in bug 1050405 comment 15. Fixing this would just involve making additional assets for the beta channel, but I'm not sure how important this is.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Not a high priority, but we'd take a "beta" preview.

Comment 3

[:Margaret Leibovic]

Antlam, do you still have the image files you used for bug 1050405? To fix this bug, we'll need a beta branded version of that search widget preview icon.

If we get the resources for that, this could be a good first bug.

Comment 4

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Attachment: sa_widgetprev_beta.zip

Here ya go!

Comment 5

[:Margaret Leibovic]

To fix this bug, you just need to swap out these images:

mobile/android/branding/beta/res/drawable-hdpi/launcher_widget.png
mobile/android/branding/beta/res/drawable-mdpi/launcher_widget.png
mobile/android/branding/beta/res/drawable-xhdpi/launcher_widget.png
mobile/android/branding/beta/res/drawable-xxhdpi/launcher_widget.png

For the new ones that are in the zip file that antlam uploaded.

Comment 6

[Allison Naaktgeboren :ally]

Attachment: switchOutImages

pending testing with special mozconfig to fake beta

Comment 7

[Allison Naaktgeboren :ally]

Comment on attachment 8568247 [details] [diff] [review]
switchOutImages

tested on galaxy s3

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8568247 [details] [diff] [review]
switchOutImages

LGTM. With images of this size, we typically try to run "trimage" or "pngcrush" to make sure the PNGs are as small as possible without losing any detail. Please try to see if you can reduce the file sizes any.

Comment 9

[Allison Naaktgeboren :ally]

Attachment: switchOutImages

pngcrush/imageoptim reports savings of 15-22%.

Comment 10

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8568679 [details] [diff] [review]
switchOutImages

I assume a visual check show no noticeable artifacts.

Comment 11

[Allison Naaktgeboren :ally]

You assume correctly, at least for nexus 5, samsung galaxy s3, and nexus 9(?) tablet.

Comment 12

[Allison Naaktgeboren :ally]

bah, tree's closed

Comment 13

[Allison Naaktgeboren :ally]

 https://hg.mozilla.org/integration/fx-team/rev/e606119f9513

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e606119f9513