1123651 - Use |StreamSocket| for NFC IPC

Status: RESOLVED FIXED

(Firefox OS Graveyard :: NFC, defect)

Description

[Thomas Zimmermann [:tzimmermann] [:tdz]]

|UnixSocketConsumer| has reached its limits and is being replaced by a combination of |StreamSocket| and |ListenSocket|. NFC shall be converted to use |StreamSocket|.

The equivalent RIL patches are in bug 1110669.

Comment 1

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [01] Bug 1123651: Fix coding style in Nfc.cpp

Comment 2

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [02] Bug 1123651: Improve correctness of |NfcConsumer| and its helpers

Comment 3

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [03] Bug 1123651: Inherit |NfcConsumer| from |StreamSocket|

Comment 4

[Thomas Zimmermann [:tzimmermann] [:tdz]]

(In reply to Thomas Zimmermann [:tzimmermann] [:tdz] from comment #3)
> Created attachment 8551763 [details] [diff] [review]
> [03] Bug 1123651: Inherit |NfcConsumer| from |StreamSocket|

|StreamSocket| works the same way as |UnixSocketConsumer|, but the listen functionality has been moved into |ListenSocket|.

Comment 5

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [02] Bug 1123651: Improve correctness of |NfcConsumer| and its helpers (v2)

Changes since v1:

  - removed keyword virtual from classes with MOZ_FINAL

Comment 6

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [03] Bug 1123651: Inherit |NfcConsumer| from |StreamSocket| (v2)

Changes since v1:

  - rebased on [02](v2)

Comment 7

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Thanks, Yoshi!

https://hg.mozilla.org/integration/b2g-inbound/rev/84c24df5a060
https://hg.mozilla.org/integration/b2g-inbound/rev/7c33110665cd
https://hg.mozilla.org/integration/b2g-inbound/rev/3c0080d39c90

https://treeherder.mozilla.org/ui/#/jobs?repo=b2g-inbound&revision=3c0080d39c90

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/84c24df5a060
https://hg.mozilla.org/mozilla-central/rev/7c33110665cd
https://hg.mozilla.org/mozilla-central/rev/3c0080d39c90