1123657 - Certain UITelemetry data for search bar UI is not correctly logged

Status: RESOLVED FIXED

(Firefox :: Search, defect, P4)

Description

[Petruta Horea [:phorea], Desktop QA]

See https://bugzilla.mozilla.org/show_bug.cgi?id=1102937#c34 and #c35

Some UITelemetry data for new Search UI is not correctly logged. Tested using latest Developer Edition 37.0a2 (2015-01-19) under Win 7 64-bit, Ubuntu 12.04 32-bit and Mac OSX 10.9.5.

*Event: 
Select a search suggestion with the mouse.
 Should log a "search" > "selection" > "searchbar" > "1" > "mouse" event.
**Results: 
Win 7: "search":{"searchbar":1}
Mac OSX: "search":{"searchbar":1,"selection":{"searchbar":{"4":{"mouse":1}}}}
Linux: "search":{"searchbar":1,"selection":{"searchbar":{"4":{"mouse":1}}}}

*Event:
Select a search suggestion with the arrows and enter key.
 Should log a "search" > "selection" > "searchbar" > "3" > "key" event
**Results:
Win 7: "search":{"searchbar":2,"selection":{"searchbar":{"3":{"key":1}}}}
Mac: "search":{"searchbar":2,"selection":{"searchbar":{"2":{"key":1},"4":{"mouse":1}}}}
Linux: "search":{"searchbar":2,"selection":{"searchbar":{"4":{"mouse":1,"key":1}}}}

*Event:
Select a search engine with the enter key while holding down alt.
 Should log a "search-oneoff" > "twitter.oneoff" > "key" > "tab" event.
**Results:
Win 7: "search-oneoff":{"twitter.oneoff":{"key":{"current":1}}}
Mac OSX: "search-oneoff":{"twitter.oneoff":{"key":{"current":1}}}
Linux: Couldn't verify due to bug 1123292

*Event:
Select the "Change Search Settings" footer with the mouse.
 Should log a "click-builtin-item" > "searchbar" > "search-settings" event.
**Results:
Win 7: "click-builtin-item":{"tabbrowser-tabs":{"left":2},"searchbar":{"left":2,"search-settings":1},"urlbar-reload-button":{"left":1}}
Mac OSX: "click-builtin-item":{"tabbrowser-tabs":{"left":10},"searchbar":{"left":3,"search-settings":2},"urlbar-reload-button":{"left":2}}
Linux: "click-builtin-item":{"tabbrowser-tabs":{"left":8},"searchbar":{"left":2},"urlbar-reload-button":{"left":1}}}

Comment 1

[Florian Quèze [:florian]]

Blake, is this something you intend to fix (or mentor someone on)? Is it something we'll want to uplift to 37 (where bug 1102937 landed)?

Comment 2

[Blake Winton (:bwinton) (:☕️)]

If no-one has picked it up, I would be happy to mentor it, and yeah, I suspect if we want data from most of our users, we want to uplift it.

(If it gets down to the wire, I could probably also take it, but developing on Windows is a bit of a pain for me.)

Comment 3

[Blake Winton (:bwinton) (:☕️)]

The code that needs investigating is https://dxr.mozilla.org/mozilla-central/source/browser/base/content/urlbarBindings.xml?from=browser/base/content/urlbarBindings.xml#928

Comment 4

[Blake Winton (:bwinton) (:☕️)]

So, I just tried to replicate the first part of this bug ("Select a search suggestion with the mouse."), but the results on Win7 look just like the ones given here for Mac and Linux.
  "search":{"searchbar":1,"selection":{"searchbar":{"4":{"mouse":1}}}}

The results given for the second part ("Select a search suggestion with the arrows and enter key.") seem correct.  (There is extra data, but it's expected based on the results for the first part.)

The results for the third part ("Select a search engine with the enter key while holding down alt.") need re-testing now that the related bug is fixed.

And since I'm running the tests on Windows, I can't replicate the fourth part ("Select the "Change Search Settings" footer with the mouse.").

Petruta, could you please re-test the third and fourth part, to see if they're still a problem?
(If you wanted to post just the Linux results, I'ld be happy to verify whether they're correct or not.)

Thank you very much!

Comment 5

[Petruta Horea [:phorea], Desktop QA]

Blake, sorry for the late answer.

I confirm that part I is correct now on Windows.

For III, bug 1123292 is wontfix for Linux. But on the remaining platforms, the results are different from expected because "tab" is missing.

As for IV, I have the same result for Ubuntu 14.04 as in comment 0 under Win 7 and Mac. 
In this case "tabbrowser-tabs":"left", "left" and "urlbar-reload-button":{"left"} are extra data in comparison with the expected results.

Comment 6

[Blake Winton (:bwinton) (:☕️)]

Hi Petruta!  Thank you so much for re-testing!  :)

The extra data in IV seems reasonable, and not unexpected.

For III, do the search results open in a new tab when you're holding down alt (or command on Mac), or do they open in the current tab?  And can you check the value of the browser.search.openintab preference?  (Oh!  Maybe you need to hold the Control key instead of the Alt key?  I might have gotten those instructions wrong…)

Comment 7

[Petruta Horea [:phorea], Desktop QA]

My bad for III, Blake, I'm sorry.

I guess I was using Alt to change the search engine from the keyboard and then press Enter to perform the search.
If I hold them in the same time, the search results are opened in a new tab and the output in telemetry is correct:
"search-oneoff":{"amazondotcom.oneoff":{"key":{"tab":1}}
I was able to verify this under Ubuntu too, but only if a one-off search engine was already highlighted - pressing simultaneously Alt+Enter can be used here too.

Using Ctrl, I get: "search-oneoff":{"wikipedia.oneoff":{"key":{"current":1}}

Please note that I used latest Nightly 39.0a1 for retesting.

Comment 8

[:shell escalante]

Hi Blake - reading through comments it looks like a lot of this isn't a bug?  how serious/are there still parts we should be fixing and if so - which ones? 

just asking as you've obviously spent time investigating :)  thanks!

Comment 9

[Blake Winton (:bwinton) (:☕️)]

Hi Shell!  I think, based on the comments, that we can mark this as fixed…  Thanks for the ping!  :)

Comment 10

[Claas Augner [:claas]]

Hi Blake, I came across this diamond bug via Bugs Ahoy. I agree with your latest comment and suggest marking this bug as fixed for real, what do you think?

Comment 11

[Blake Winton (:bwinton) (:☕️)]

Sure.  Make it so.  ;)  (Thanks!)

Comment 12

[Blake Winton (:bwinton) (:☕️)]

(Uh, I forgot to ask, can you mark this bug as fixed, or do you need me to do it?)

Comment 13

[Claas Augner [:claas]]

Thanks, I can, and did.