1123669 - [FFOS][PDM] Video cannot be re-played in Video APP after playback ends and goes back to the beginning

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Blake Wu [:bwu][:blakewu]]

In http streaming case, this bug will not be found.

Comment 1

[Blake Wu [:bwu][:blakewu]]

The rootcause are mentioned in bug 1131467 comment 5 and audio decoder manager doesn't implement the override flush().

Comment 2

[Blake Wu [:bwu][:blakewu]]

Attachment: Bug-1123669-Reset-mDrainComplete-flag-and-implement-.patch

The rootcause is explained in comment 1. 
This patch is on top of Attachment #8563269 [details] [diff] in bug 1127654.

Comment 3

[Alfredo Yang (:alfredo)]

Comment on attachment 8564844 [details] [diff] [review]
Bug-1123669-Reset-mDrainComplete-flag-and-implement-.patch

Review of attachment 8564844 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm

Comment 4

[Blake Wu [:bwu][:blakewu]]

Attachment: Bug-1123669-Reset-mDrainComplete-flag-and-implement-flush.patch

Carry r+ from ajones.

Comment 5

[Blake Wu [:bwu][:blakewu]]

Tryserver:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6f1c325d64d8

Comment 6

[Blake Wu [:bwu][:blakewu]]

(In reply to Blake Wu [:bwu][:blakewu] from comment #5)
> Tryserver:
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=6f1c325d64d8
Testing results look good!

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1219ad286c50

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1219ad286c50