1123696 - Sync's util.js checks for BrowserPreferences ID on the preferences implementation but the in-content preferences doesn't use BrowserPreferences as an ID

Status: RESOLVED INVALID

(Firefox :: Settings UI, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

http://mxr.mozilla.org/mozilla-central/search?string=BrowserPreferences

http://hg.mozilla.org/mozilla-central/annotate/c2df1daf74c3/browser/base/content/sync/utils.js#l29

http://hg.mozilla.org/mozilla-central/annotate/c2df1daf74c3/browser/components/preferences/preferences.xul#l37

We need to investigate if this means that the in-content preferences are broken here and if they are we'll either want to add the BrowserPreferences ID or fix up the Sync code to not rely on this ID.

Comment 1

[Mark Hammond [:markh] [:mhammond]]

I haven't looked at the CSS selectors, but the code in utils.js can probably be easily tweaked if it is a problem in practice (and I haven't noticed any such problems in practice - a quick glance implies the code will just fall back to opening in a tab, which is the right thing)

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

The CSS selectors should be handled by bug 1120189. Looks like we can close this as invalid.

We will want to remove this code was in-content preferences has shipped and we're sure it's gonna stick, but it may be a better idea to do a code audit at that point instead of having a bunch of code cleanup bugs filed well in advance.