1123844 - Mark virtual overridden functions as MOZ_OVERRIDE in widget/gtk, and a few headers used in widget/gtk

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Daniel Holbert [:dholbert]]

Goal of this bug: be able to run "./mach build widget" on linux without any -Winconsistent-missing-override warnings in clang 3.6.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix v1

This patch adds MOZ_OVERRIDE to all of the methods that trigger -Winconsistent-missing-override warnings in mozilla-central.

In some cases (where easy/obvious), I also rewrapped lines or adjusted indentation to avoid going over 80 characters (or going too far over 80 characters).  I didn't bother in cases where the function just takes one arg (and hence the line-wrapping opportunity is non-obvious), or in some cases where contextual code was already much longer than 80 characters.

I also added 'virtual' annotations to some function-decls that were missing the annotation. (This annotation has to be valid -- i.e. I'm not *converting* anything to be virtual.  If I were, the accompanying MOZ_OVERRIDE annotations would trigger compiler errors.)

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: fix v1 (now with commit message)

Sorry, forgot to add commit message. Added that in this version.

Comment 3

[Daniel Holbert [:dholbert]]

Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=50dec32593c7

Comment 4

[Daniel Holbert [:dholbert]]

Rebased to not be on top of bug 1123836 (hence, removing that dependency), and landed:
https://hg.mozilla.org/integration/mozilla-inbound/rev/136a16151e6b

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/136a16151e6b