Closed Bug 1123844 Opened 6 years ago Closed 6 years ago

Mark virtual overridden functions as MOZ_OVERRIDE in widget/gtk, and a few headers used in widget/gtk

Categories

(Core :: Widget: Gtk, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla38

People

(Reporter: dholbert, Assigned: dholbert)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

Goal of this bug: be able to run "./mach build widget" on linux without any -Winconsistent-missing-override warnings in clang 3.6.
Depends on: 1123836
Attached patch fix v1 (obsolete) — Splinter Review
This patch adds MOZ_OVERRIDE to all of the methods that trigger -Winconsistent-missing-override warnings in mozilla-central.

In some cases (where easy/obvious), I also rewrapped lines or adjusted indentation to avoid going over 80 characters (or going too far over 80 characters).  I didn't bother in cases where the function just takes one arg (and hence the line-wrapping opportunity is non-obvious), or in some cases where contextual code was already much longer than 80 characters.

I also added 'virtual' annotations to some function-decls that were missing the annotation. (This annotation has to be valid -- i.e. I'm not *converting* anything to be virtual.  If I were, the accompanying MOZ_OVERRIDE annotations would trigger compiler errors.)
Attachment #8551952 - Flags: review?(karlt)
Sorry, forgot to add commit message. Added that in this version.
Attachment #8551952 - Attachment is obsolete: true
Attachment #8551952 - Flags: review?(karlt)
Attachment #8551955 - Flags: review?(karlt)
Attachment #8551955 - Flags: review?(karlt) → review+
Rebased to not be on top of bug 1123836 (hence, removing that dependency), and landed:
https://hg.mozilla.org/integration/mozilla-inbound/rev/136a16151e6b
No longer depends on: 1123836
Flags: in-testsuite-
https://hg.mozilla.org/mozilla-central/rev/136a16151e6b
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in before you can comment on or make changes to this bug.