1123878 - TestCompositor.cpp:36:27: warning: 'GetClientBounds' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Daniel Holbert [:dholbert]]

Build warnings with clang 3.6:
{
gfx/tests/gtest/TestCompositor.cpp:36:27 [-Winconsistent-missing-override] 'GetClientBounds' overrides a member function but is not marked 'override'
gfx/tests/gtest/TestCompositor.cpp:40:27 [-Winconsistent-missing-override] 'GetBounds' overrides a member function but is not marked 'override'
gfx/tests/gtest/TestCompositor.cpp:54:27 [-Winconsistent-missing-override] 'Create' overrides a member function but is not marked 'override'
gfx/tests/gtest/TestCompositor.cpp:59:27 [-Winconsistent-missing-override] 'Show' overrides a member function but is not marked 'override'
gfx/tests/gtest/TestCompositor.cpp:60:27 [-Winconsistent-missing-override] 'IsVisible' overrides a member function but is not marked 'override'
gfx/tests/gtest/TestCompositor.cpp:61:27 [-Winconsistent-missing-override] 'ConstrainPosition' overrides a member function but is not marked 'override'
gfx/tests/gtest/TestCompositor.cpp:63:27 [-Winconsistent-missing-override] 'Move' overrides a member function but is not marked 'override'
gfx/tests/gtest/TestCompositor.cpp:64:27 [-Winconsistent-missing-override] 'Resize' overrides a member function but is not marked 'override'
gfx/tests/gtest/TestCompositor.cpp:65:27 [-Winconsistent-missing-override] 'Resize' overrides a member function but is not marked 'override'
gfx/tests/gtest/TestCompositor.cpp:68:27 [-Winconsistent-missing-override] 'Enable' overrides a member function but is not marked 'override'
gfx/tests/gtest/TestCompositor.cpp:69:27 [-Winconsistent-missing-override] 'IsEnabled' overrides a member function but is not marked 'override'
gfx/tests/gtest/TestCompositor.cpp:70:27 [-Winconsistent-missing-override] 'SetFocus' overrides a member function but is not marked 'override'
gfx/tests/gtest/TestCompositor.cpp:71:27 [-Winconsistent-missing-override] 'ConfigureChildren' overrides a member function but is not marked 'override'
gfx/tests/gtest/TestCompositor.cpp:72:27 [-Winconsistent-missing-override] 'Invalidate' overrides a member function but is not marked 'override'
gfx/tests/gtest/TestCompositor.cpp:73:27 [-Winconsistent-missing-override] 'SetTitle' overrides a member function but is not marked 'override'
gfx/tests/gtest/TestCompositor.cpp:74:27 [-Winconsistent-missing-override] 'WidgetToScreenOffset' overrides a member function but is not marked 'override'
gfx/tests/gtest/TestCompositor.cpp:75:27 [-Winconsistent-missing-override] 'DispatchEvent' overrides a member function but is not marked 'override'
gfx/tests/gtest/TestCompositor.cpp:77:27 [-Winconsistent-missing-override] 'CaptureRollupEvents' overrides a member function but is not marked 'override'
gfx/tests/gtest/TestCompositor.cpp:78:27 [-Winconsistent-missing-override] 'SetInputContext' overrides a member function but is not marked 'override'
gfx/tests/gtest/TestCompositor.cpp:80:29 [-Winconsistent-missing-override] 'GetInputContext' overrides a member function but is not marked 'override'
gfx/tests/gtest/TestCompositor.cpp:81:27 [-Winconsistent-missing-override] 'ReparentNativeWidget' overrides a member function but is not marked 'override'
}

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix v1: add MOZ_OVERRIDE all over the place

Comment 2

[Benoit Girard (:BenWa)]

Comment on attachment 8552002 [details] [diff] [review]
fix v1: add MOZ_OVERRIDE all over the place

Review of attachment 8552002 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 3

[Daniel Holbert [:dholbert]]

Thanks! Landed:
https://hg.mozilla.org/integration/mozilla-inbound/rev/82ffa906548c

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/82ffa906548c