Closed Bug 1123878 Opened 5 years ago Closed 5 years ago

TestCompositor.cpp:36:27: warning: 'GetClientBounds' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]

Categories

(Core :: Graphics, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla38

People

(Reporter: dholbert, Assigned: dholbert)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Build warnings with clang 3.6:
{
gfx/tests/gtest/TestCompositor.cpp:36:27 [-Winconsistent-missing-override] 'GetClientBounds' overrides a member function but is not marked 'override'
gfx/tests/gtest/TestCompositor.cpp:40:27 [-Winconsistent-missing-override] 'GetBounds' overrides a member function but is not marked 'override'
gfx/tests/gtest/TestCompositor.cpp:54:27 [-Winconsistent-missing-override] 'Create' overrides a member function but is not marked 'override'
gfx/tests/gtest/TestCompositor.cpp:59:27 [-Winconsistent-missing-override] 'Show' overrides a member function but is not marked 'override'
gfx/tests/gtest/TestCompositor.cpp:60:27 [-Winconsistent-missing-override] 'IsVisible' overrides a member function but is not marked 'override'
gfx/tests/gtest/TestCompositor.cpp:61:27 [-Winconsistent-missing-override] 'ConstrainPosition' overrides a member function but is not marked 'override'
gfx/tests/gtest/TestCompositor.cpp:63:27 [-Winconsistent-missing-override] 'Move' overrides a member function but is not marked 'override'
gfx/tests/gtest/TestCompositor.cpp:64:27 [-Winconsistent-missing-override] 'Resize' overrides a member function but is not marked 'override'
gfx/tests/gtest/TestCompositor.cpp:65:27 [-Winconsistent-missing-override] 'Resize' overrides a member function but is not marked 'override'
gfx/tests/gtest/TestCompositor.cpp:68:27 [-Winconsistent-missing-override] 'Enable' overrides a member function but is not marked 'override'
gfx/tests/gtest/TestCompositor.cpp:69:27 [-Winconsistent-missing-override] 'IsEnabled' overrides a member function but is not marked 'override'
gfx/tests/gtest/TestCompositor.cpp:70:27 [-Winconsistent-missing-override] 'SetFocus' overrides a member function but is not marked 'override'
gfx/tests/gtest/TestCompositor.cpp:71:27 [-Winconsistent-missing-override] 'ConfigureChildren' overrides a member function but is not marked 'override'
gfx/tests/gtest/TestCompositor.cpp:72:27 [-Winconsistent-missing-override] 'Invalidate' overrides a member function but is not marked 'override'
gfx/tests/gtest/TestCompositor.cpp:73:27 [-Winconsistent-missing-override] 'SetTitle' overrides a member function but is not marked 'override'
gfx/tests/gtest/TestCompositor.cpp:74:27 [-Winconsistent-missing-override] 'WidgetToScreenOffset' overrides a member function but is not marked 'override'
gfx/tests/gtest/TestCompositor.cpp:75:27 [-Winconsistent-missing-override] 'DispatchEvent' overrides a member function but is not marked 'override'
gfx/tests/gtest/TestCompositor.cpp:77:27 [-Winconsistent-missing-override] 'CaptureRollupEvents' overrides a member function but is not marked 'override'
gfx/tests/gtest/TestCompositor.cpp:78:27 [-Winconsistent-missing-override] 'SetInputContext' overrides a member function but is not marked 'override'
gfx/tests/gtest/TestCompositor.cpp:80:29 [-Winconsistent-missing-override] 'GetInputContext' overrides a member function but is not marked 'override'
gfx/tests/gtest/TestCompositor.cpp:81:27 [-Winconsistent-missing-override] 'ReparentNativeWidget' overrides a member function but is not marked 'override'
}
Depends on: 1068190
Summary: estCompositor.cpp:36:27: warning: 'GetClientBounds' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] → TestCompositor.cpp:36:27: warning: 'GetClientBounds' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
Attachment #8552002 - Attachment description: fix v1 → fix v1: add MOZ_OVERRIDE all over the place
Comment on attachment 8552002 [details] [diff] [review]
fix v1: add MOZ_OVERRIDE all over the place

Review of attachment 8552002 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8552002 - Flags: review?(bgirard) → review+
https://hg.mozilla.org/mozilla-central/rev/82ffa906548c
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in before you can comment on or make changes to this bug.