Fix -Winconsistent-missing-override warnings in X11-related headers within gfx/layers

RESOLVED FIXED in mozilla38

Status

()

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: dholbert, Assigned: dholbert)

Tracking

(Blocks 1 bug)

Trunk
mozilla38
x86_64
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

I get a few -Winconsistent-missing-override build warnings in gfx/layers code, for X11-related headers. (I suspect ehsan fixed the warnings that are spammed on Mac, in some other dependency of bug 1117034, and that just leaves a bit of non-mac code like these X11 headers.)

The warnings are:
{
gfx/layers/basic/X11TextureSourceBasic.h:36:16: warning: 'SetCompositor' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]

gfx/layers/composite/X11TextureHost.h:44:23: warning: 'Name' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]

dist/include/mozilla/layers/TextureClientX11.h:46:30: warning: 'GetFormat' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
}

Fix coming up.
Posted patch fix v1Splinter Review
Attachment #8552017 - Flags: review?(bgirard)
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Comment on attachment 8552017 [details] [diff] [review]
fix v1

Review of attachment 8552017 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for doing this work, override checking can catch real mistakes when refactoring.
Attachment #8552017 - Flags: review?(bgirard) → review+
Thanks for the review!

> override checking can catch real mistakes when refactoring

(Incidentally, I did find a minor mistake while doing this fixup earlier today, which has been around for ~15 years, and has been cribbed several times: bug 1123836, if you're curious)
https://hg.mozilla.org/mozilla-central/rev/fa1d80fd45c5
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in before you can comment on or make changes to this bug.