Closed
Bug 1123893
Opened 9 years ago
Closed 9 years ago
Fix -Winconsistent-missing-override warnings in X11-related headers within gfx/layers
Categories
(Core :: Graphics: Layers, defect)
Tracking
()
RESOLVED
FIXED
mozilla38
People
(Reporter: dholbert, Assigned: dholbert)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
2.62 KB,
patch
|
BenWa
:
review+
|
Details | Diff | Splinter Review |
I get a few -Winconsistent-missing-override build warnings in gfx/layers code, for X11-related headers. (I suspect ehsan fixed the warnings that are spammed on Mac, in some other dependency of bug 1117034, and that just leaves a bit of non-mac code like these X11 headers.) The warnings are: { gfx/layers/basic/X11TextureSourceBasic.h:36:16: warning: 'SetCompositor' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] gfx/layers/composite/X11TextureHost.h:44:23: warning: 'Name' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] dist/include/mozilla/layers/TextureClientX11.h:46:30: warning: 'GetFormat' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] } Fix coming up.
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8552017 -
Flags: review?(bgirard)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Comment 2•9 years ago
|
||
Comment on attachment 8552017 [details] [diff] [review] fix v1 Review of attachment 8552017 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for doing this work, override checking can catch real mistakes when refactoring.
Attachment #8552017 -
Flags: review?(bgirard) → review+
Assignee | ||
Comment 3•9 years ago
|
||
Thanks for the review! > override checking can catch real mistakes when refactoring (Incidentally, I did find a minor mistake while doing this fixup earlier today, which has been around for ~15 years, and has been cribbed several times: bug 1123836, if you're curious)
Assignee | ||
Comment 4•9 years ago
|
||
Landed, but with the wrong bug number (oops): https://hg.mozilla.org/integration/mozilla-inbound/rev/e0ada286eea0 Backed out... https://hg.mozilla.org/integration/mozilla-inbound/rev/b939c20dc8d8 ...and re-landed w/ correct bug number: https://hg.mozilla.org/integration/mozilla-inbound/rev/fa1d80fd45c5
Comment 5•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/fa1d80fd45c5
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in
before you can comment on or make changes to this bug.
Description
•