1123893 - Fix -Winconsistent-missing-override warnings in X11-related headers within gfx/layers

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Daniel Holbert [:dholbert]]

I get a few -Winconsistent-missing-override build warnings in gfx/layers code, for X11-related headers. (I suspect ehsan fixed the warnings that are spammed on Mac, in some other dependency of bug 1117034, and that just leaves a bit of non-mac code like these X11 headers.)

The warnings are:
{
gfx/layers/basic/X11TextureSourceBasic.h:36:16: warning: 'SetCompositor' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]

gfx/layers/composite/X11TextureHost.h:44:23: warning: 'Name' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]

dist/include/mozilla/layers/TextureClientX11.h:46:30: warning: 'GetFormat' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
}

Fix coming up.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix v1

Comment 2

[Benoit Girard (:BenWa)]

Comment on attachment 8552017 [details] [diff] [review]
fix v1

Review of attachment 8552017 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for doing this work, override checking can catch real mistakes when refactoring.

Comment 3

[Daniel Holbert [:dholbert]]

Thanks for the review!

> override checking can catch real mistakes when refactoring

(Incidentally, I did find a minor mistake while doing this fixup earlier today, which has been around for ~15 years, and has been cribbed several times: bug 1123836, if you're curious)

Comment 4

[Daniel Holbert [:dholbert]]

Landed, but with the wrong bug number (oops):
https://hg.mozilla.org/integration/mozilla-inbound/rev/e0ada286eea0

Backed out...
  https://hg.mozilla.org/integration/mozilla-inbound/rev/b939c20dc8d8
...and re-landed w/ correct bug number:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fa1d80fd45c5

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/fa1d80fd45c5