1124006 - Remove shrink comments in browser_toolbar.xml

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

A few comments in the mobile/android/base/resources/layout/browser_toolbar.xml file are out of date: we no longer shrink the toolbar so any references to that should be removed. Specifically:

* [1]: Note 2 should be entirely removed
* [2]: Here, references to shrinking should be removed

To start, set up a build environment - you can see the instructions here: https://wiki.mozilla.org/Mobile/Fennec/Android

If you need any help, you can reply to this bug, or feel free to message me on IRC - my nick is "mcomella" and you can find me in #mobile. If you need IRC setup instructions, see https://wiki.mozilla.org/IRC

Thanks and happy coding! ^_^

[1]: https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/resources/layout/browser_toolbar.xml?rev=540bc6af7020#11
[2]: https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/resources/layout/browser_toolbar.xml?rev=540bc6af7020#28

Comment 1

[James Dearing]

Attachment: 0001-Removed-a-couple-of-comments-fixes-bug-1124006.patch

This is my first code contribution to Mozilla. My mentor, Benjamin Kerensa, suggested I fix this bug.

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Hey, James - welcome to Bugzilla! I've assigned you to the bug.

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8553504 [details] [diff] [review]
0001-Removed-a-couple-of-comments-fixes-bug-1124006.patch

Review of attachment 8553504 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me! Thanks for your help, James!

To get your patch checked in, add the "checkin-needed" keyword. Note that all patches checked in via "checkin-needed" require a successful push to our try test servers. Here's the push (yes, even though it was just a few comments):

https://treeherder.mozilla.org/#/jobs?repo=try&revision=042de30c86e0

When it's green, add the keyword!

[1]: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch#Getting_the_patch_checked_into_the_tree

Comment 4

[Carsten Book [:Tomcat]]

Thanks James for contributing to Mozilla - i just did checkin for this change!

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/25d0517185f6

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/25d0517185f6

Comment 7

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Nice work, James!

If Benjamin hasn't suggested any followup bugs, may I suggest bug 1110350 for some front-end work or bug 1121651 for some test work. For a list of our other good second bugs, please see [1].

[1]: https://bugzilla.mozilla.org/buglist.cgi?f1=status_whiteboard&list_id=11922240&o1=substring&query_format=advanced&bug_status=UNCONFIRMED&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&v1=[good%20second%20bug]&product=Android%20Background%20Services&product=Firefox%20for%20Android

Comment 8

[James Dearing]

Thanks, Michael. I'll take a look at those bugs first chance I get!