1124129 - "WARNING: content window passed to PrivateBrowsingUtils.isWindowPrivate. Use isContentWindowPrivate instead" from aboutPrivateBrowsing.js

Status: RESOLVED FIXED

(Firefox :: Private Browsing, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Not sure why you do not see this logging output when opening the page manually, but I do. The stack is way smaller so maybe we can find out the problem and get this fixed.

Steps:
1. Start Firefox from the command line (maybe dumps have to be enabled)
2. Load "about:privatebrowsing" via the locationbar
3. Observe the warnings in the terminal

Here two warnings which are spit out right after each other:

WARNING: content window passed to PrivateBrowsingUtils.isWindowPrivate. Use isContentWindowPrivate instead (but only for frame scripts).
pbu_isWindowPrivate@resource://gre/modules/PrivateBrowsingUtils.jsm:25:14
@chrome://browser/content/aboutPrivateBrowsing.js:12:6

WARNING: content window passed to PrivateBrowsingUtils.isWindowPrivate. Use isContentWindowPrivate instead (but only for frame scripts).
pbu_isWindowPrivate@resource://gre/modules/PrivateBrowsingUtils.jsm:25:14
@chrome://browser/content/aboutPrivateBrowsing.js:37:8

Here the appropriate code:

12 if (!PrivateBrowsingUtils.isWindowPrivate(window)) {
13   document.title = stringBundle.GetStringFromName("title.normal");
14   setFavIcon("chrome://global/skin/icons/question-16.png");
15 } else {
[..]
36 document.addEventListener("DOMContentLoaded", function () {
37   if (!PrivateBrowsingUtils.isWindowPrivate(window)) {
38     document.body.setAttribute("class", "normal");
39   }

Regressor seems to be bug 1069059 which landed in the timeframe of Firefox 35.

Comment 1

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: fix-pb

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 8552604 [details] [diff] [review]
fix-pb

Review of attachment 8552604 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/privatebrowsing/content/aboutPrivateBrowsing.js
@@ +33,5 @@
>    head.insertBefore(icon, head.firstChild);
>  }
>  
>  document.addEventListener("DOMContentLoaded", function () {
> +  if (!PrivateBrowsingUtils.isContentWindowPrivate(window)) {

Doesn't it also need the change in line 12 too?

Comment 3

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: fix-pb 2

Yeah, guess so.

Comment 4

[(no longer active)]

Comment on attachment 8552633 [details] [diff] [review]
fix-pb 2

Review of attachment 8552633 [details] [diff] [review]:
-----------------------------------------------------------------

Haha, I just wrote the same patch, and Bugzilla suggested this bug when filing my bug.  :-)

r=me

Comment 5

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/920ae6ac243b

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/920ae6ac243b

Comment 7

[jaikens03]

This was closed on January 23 2015. It's now June 27 2015 and I'm seeing WARNING: content window passed to PrivateBrowsingUtils.isWindowPrivate. Use isContentWindowPrivate instead (but only for frame scripts).
pbu_isWindowPrivate@resource://gre/modules/PrivateBrowsingUtils.jsm:25:14
nsBrowserAccess.prototype.openURI@chrome://browser/content/browser.js:15320:21

So, clearly this was not fixed.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Jaikens03, that is a different stack and would need a new bug filed. Your issue comes from browser.js while mine was from aboutPrivateBrowsing.js

Comment 9

[mario]

2015 08 09 
Linux localhost.localdomain 4.1.3-201.fc22.i686+PAE #1 SMP Wed Jul 29 20:36:37 UTC 2015 i686 i686 i386 GNU/Linux (Fedora 22)
Mozilla Firefox 39.0.3

step 1,2,3 as sugegsted by Henrik Skupin:
> firefox
(firefox:12594): GLib-GObject-WARNING **: The property GtkSettings:gtk-menu-images is deprecated and shouldn't be used anymore. It will be removed in a future version.
WARNING: content window passed to PrivateBrowsingUtils.isWindowPrivate. Use isContentWindowPrivate instead (but only for frame scripts).
pbu_isWindowPrivate@resource://gre/modules/PrivateBrowsingUtils.jsm:25:14
nsBrowserAccess.prototype.openURI@chrome://browser/content/browser.js:15418:21

is there something to be fixed?

Comment 10

[Nickolay_Ponomarev]

> (In reply to mario from comment #9)
mario filed bug 1192601.