1124150 - Remove dead code & data structure from xml2dict.py, Write documentation regarding dictionary blob and predictions

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[John Lu [:mnjul][Please NI or I'll miss]]

The current Latin dictionary blob generation code [1] has had some dead code / data structure since bug 865484 which is almost 2 years ago. I talked with :djf about them and we agree that those dead codes may be removed to avoid confusion and to maintain consistency with the upcoming patch of bug 1102834.

[1] https://github.com/mozilla-b2g/gaia/blob/master/apps/keyboard/js/imes/latin/dictionaries/xml2dict.py has

Comment 1

[John Lu [:mnjul][Please NI or I'll miss]]

Alright I'm on this.

What I'm attempting in this bug is not just removing the dead code -- that can be done within minutes plus testing -- I'll study the codes (both xml2dict.py and predictions.js) and also amend comments where needed.

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] mnjul:bug_1124150_xml2dict_predictions_annotation > mozilla-b2g:master

Comment 3

[John Lu [:mnjul][Please NI or I'll miss]]

Comment on attachment 8564018 [details] [review]
[gaia] mnjul:bug_1124150_xml2dict_predictions_annotation > mozilla-b2g:master

Tim, please check the patch mostly for commentary purposes, thanks.

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8564018 [details] [review]
[gaia] mnjul:bug_1124150_xml2dict_predictions_annotation > mozilla-b2g:master

Sorry for the late review!

Comment 5

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/bdb089fcfd337fc3fe064cdcb6eeaf5689c807e9