112436 - Some functions in nsATSUIToolkit has to take length

Status: VERIFIED FIXED

(Core :: Internationalization, defect)

Description

[nhottanscp]

The current usage of ATSUI is per character base, it draws only one 
character per time. But the interfaces should be more generic, it should 
take a length along with the string pointer in PRUnichar* and they should 
not hard code a length as one.

Index: mozilla/gfx/src/mac/nsATSUIUtils.h
=========================================================
==========
RCS file: /cvsroot/mozilla/gfx/src/mac/nsATSUIUtils.h,v
retrieving revision 1.7
diff -c -0 -r1.7 nsATSUIUtils.h
*** nsATSUIUtils.h	2001/10/26 20:54:02	1.7
--- nsATSUIUtils.h	2001/11/28 17:50:58
***************
*** 77 ****
!   nsresult GetTextDimensions(const PRUnichar *aCharPt, 
nsTextDimensions &oDim, 
--- 77 ----
!   nsresult GetTextDimensions(const PRUnichar *aCharPt, PRUint32 
aLength, nsTextDimensions &oDim, 
***************
*** 80 ****
!   nsresult DrawString(const PRUnichar *aCharPt, PRInt32 x, PRInt32 y, 
short &oWidth, 
--- 80 ----
!   nsresult DrawString(const PRUnichar *aCharPt, PRUint32 aLength, 
PRInt32 x, PRInt32 y, short &oWidth, 
***************
*** 85 ****
!   void StartDraw(const PRUnichar *aCharPt, short aSize, short fontNum, 
PRBool aBold,
--- 85 ----
!   void StartDraw(const PRUnichar *aCharPt, PRUint32 aLength, short 
aSize, short fontNum, PRBool aBold,

Comment 1

[Greg K.]

Does the ATSUI patch in bug 121540 address this?

Comment 2

[nhottanscp]

bug 128263 will fix this

Comment 3

[Frank Tang]

fixed and check in 

Comment 4

[Teruko Kobayashi]

Verified.