1124432 - Backport upstream bug 1079065 to bmo/4.2 to fix improper use of open() calls

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: General, defect)

Description

[David Lawrence [:dkl]]

SSIA

Comment 1

[David Lawrence [:dkl]]

Attachment: 1124432_1.patch

Comment 2

[:glob ✱]

Comment on attachment 8552724 [details] [diff] [review]
1124432_1.patch

Review of attachment 8552724 [details] [diff] [review]:
-----------------------------------------------------------------

there's a few open calls you missed: 

Bugzilla/PatchReader/Raw.pm
237:  open FILE, $filename or die "Could not open $filename: $!";

Bugzilla/PatchReader/AddCVSContext.pm
193:    open my $fh, $this->{FILENAME} or die "Could not open $this->{FILENAME}";

Bugzilla/Send/Sendmail.pm
32:    open($pipe, "| $mailer -t -oi @args")

metrics.pl
38:    open(STDIN, '</dev/null');
39:    open(STDOUT, '>/dev/null');
40:    open(STDERR, '>/dev/null');

sentry.pl
43:open(STDIN, '</dev/null');
44:open(STDOUT, '>/dev/null');
45:open(STDERR, '>/dev/null');

Comment 3

[David Lawrence [:dkl]]

Attachment: 1124432_2.patch

Sorry I missed those. Hopefully got them all this time.

dkl

Comment 4

[:glob ✱]

Comment on attachment 8553345 [details] [diff] [review]
1124432_2.patch

Review of attachment 8553345 [details] [diff] [review]:
-----------------------------------------------------------------

r=glob

Comment 5

[:glob ✱]

To ssh://[e-mail]/webtools/bmo/bugzilla.git
   a748745..9024481  master -> master