Closed
Bug 1124432
Opened 9 years ago
Closed 9 years ago
Backport upstream bug 1079065 to bmo/4.2 to fix improper use of open() calls
Categories
(bugzilla.mozilla.org :: General, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: dkl, Assigned: dkl)
References
Details
Attachments
(1 file, 1 obsolete file)
10.91 KB,
patch
|
glob
:
review+
|
Details | Diff | Splinter Review |
SSIA
Assignee | ||
Comment 1•9 years ago
|
||
Assignee | ||
Updated•9 years ago
|
Comment on attachment 8552724 [details] [diff] [review] 1124432_1.patch Review of attachment 8552724 [details] [diff] [review]: ----------------------------------------------------------------- there's a few open calls you missed: Bugzilla/PatchReader/Raw.pm 237: open FILE, $filename or die "Could not open $filename: $!"; Bugzilla/PatchReader/AddCVSContext.pm 193: open my $fh, $this->{FILENAME} or die "Could not open $this->{FILENAME}"; Bugzilla/Send/Sendmail.pm 32: open($pipe, "| $mailer -t -oi @args") metrics.pl 38: open(STDIN, '</dev/null'); 39: open(STDOUT, '>/dev/null'); 40: open(STDERR, '>/dev/null'); sentry.pl 43:open(STDIN, '</dev/null'); 44:open(STDOUT, '>/dev/null'); 45:open(STDERR, '>/dev/null');
Attachment #8552724 -
Flags: review?(glob) → review-
Assignee | ||
Comment 3•9 years ago
|
||
Sorry I missed those. Hopefully got them all this time. dkl
Attachment #8552724 -
Attachment is obsolete: true
Attachment #8553345 -
Flags: review?(glob)
Comment on attachment 8553345 [details] [diff] [review] 1124432_2.patch Review of attachment 8553345 [details] [diff] [review]: ----------------------------------------------------------------- r=glob
Attachment #8553345 -
Flags: review?(glob) → review+
To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git a748745..9024481 master -> master
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•