1124694 - [Ui Tour]Searchpanel bad positioning while moving the FF window.

Status: RESOLVED WORKSFORME

(Firefox :: Tours, defect)

Description

[Catalin Varga [QA][:VarCat]]

Attachment: printsc.jpg

Environment:

FF 35
Build Id: 20150108202552
OS: Win 7 x64, Mac Os X 10.9.5

STR:

1. Start FF with a new profile.
2. Add an entry in the searchbar.
3. Move the FF window

Issue:
Moving the FF window while the searchbarpanel is opened for the first time and the Ui Tour is present will create a miss-positioning of the panel.

This bug is reproducible on FF 34 so it doesn't seem to be a regression.

Comment 1

[ankouc]

Can you point me to the relevant code?

Comment 2

[ankouc]

Attachment: resolved by calling the good functions

Comment 3

[ankouc]

Attachment: MovingSearchPanelBug.patch

the same with some typo correction

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8554896 [details] [diff] [review]
MovingSearchPanelBug.patch

302 to florian who worked on the search stuff.

Comment 5

[Florian Quèze [:florian]]

Comment on attachment 8554896 [details] [diff] [review]
MovingSearchPanelBug.patch

Unfortunately, I don't fully understand what this code is trying to do. Moving the request to Dave who wrote this code. Sorry for the delay.

Comment 6

[Dave Townsend [:mossop]]

Comment on attachment 8554896 [details] [diff] [review]
MovingSearchPanelBug.patch

This looks like it will break keeping the main panel open when interacting with the tour panels. Besides the plan is to remove this feature in bug 1123620

Comment 7

[:Gavin Sharp [email: [e-mail]]]

No longer relevant due to bug 1123620.