1123620 - remove the one-time intro popup for the new searchbox UI

Status: RESOLVED FIXED

(Firefox :: Search, defect)

Description

[Florian Quèze [:florian]]

The UITour added in Firefox 34 for the new searchbox UI was meant to help users upgrading Firefox. For new Firefox users, it is in their way, and is probably not among the first things they should be seeing after starting to use Firefox.

I think at this point it would make sense to just remove these panels.

needinfo'ing Philipp to ensure he agrees these panels should be removed before we actually do it.

Comment 1

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

I generally agree. We would have to make sure that the countries that don't have the UI yet still get the panels. But since I assume that we wouldn't uplift this change, that shouldn't be a problem.

Michael, since you're doing a lot of onboarding stuff at the moment, how do you see the value of these panels? Do you see a scenario where we would still use them, say, as part of a tour?

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Their costs (see dependencies) are outweighing the benefits right now, so we should get rid of them. If we want to introduce something better later we can do that.

Comment 3

[Florian Quèze [:florian]]

Attachment: Patch

This is more or less a direct backout of bug 1101654, except it was done by hand because most of the files have been modified since that landed.

Try looks green: https://treeherder.mozilla.org/#/jobs?repo=try&revision=241e48de6696

I have some hesitations on 2 points:
- Should I remove the 2 mentions of the pref from the addon-sdk test files (http://mxr.mozilla.org/mozilla-central/search?string=highlightcount&find=addon-sdk)? They landed in bug 1114752. My guess is it's fine to leave them there, as this code doesn't seem to be developed in mozilla-central, but Erik, please correct me if this is wrong.

- Instead of removing pref("browser.search.highlightCount", 5); from firefox.js, should we instead set that pref to 0 for one cycle, so that profiles automatically get cleaned up when upgrading?
We could also just set that pref to 0 on aurora/beta instead of uplifting the backout, so that the panel (and the bugs it causes) disappear immediately with a very low risk patch.

Comment 4

[Florian Quèze [:florian]]

(In reply to Florian Quèze [:florian] [:flo] from comment #3)

> - Instead of removing pref("browser.search.highlightCount", 5); from
> firefox.js, should we instead set that pref to 0 for one cycle, so that
> profiles automatically get cleaned up when upgrading?
> We could also just set that pref to 0 on aurora/beta instead of uplifting
> the backout, so that the panel (and the bugs it causes) disappear
> immediately with a very low risk patch.

I thought about this a bit more. 36 will be the first time we ship the new search UI to all locales, and the panel has actually been localized in 36 for the first time, so I think we should keep it as is on 36.

On 37 I think we should just uplift a patch setting the pref to 0 by default. This will also cleanup the pref for users who have already seen the panel.

And then for 38 we should remove the panel (the patch attached here).

Comment 5

[Erik Vold [:erikvold] (please needinfo? me)]

(In reply to Florian Quèze [:florian] [:flo] from comment #3)
> Created attachment 8562109 [details] [diff] [review]
> Patch
> 
> This is more or less a direct backout of bug 1101654, except it was done by
> hand because most of the files have been modified since that landed.
> 
> Try looks green:
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=241e48de6696
> 
> I have some hesitations on 2 points:
> - Should I remove the 2 mentions of the pref from the addon-sdk test files
> (http://mxr.mozilla.org/mozilla-central/
> search?string=highlightcount&find=addon-sdk)? They landed in bug 1114752. My
> guess is it's fine to leave them there, as this code doesn't seem to be
> developed in mozilla-central, but Erik, please correct me if this is wrong.

If you are removing the `browser.search.highlightCount` pref then it's fine to remove those refs in the addon-sdk.

Comment 6

[Florian Quèze [:florian]]

Attachment: Patch v2

Now also removing the mentions of the pref in the add-on SDK.

Comment 7

[Florian Quèze [:florian]]

Attachment: Disable for 37

Comment 8

[Florian Quèze [:florian]]

https://hg.mozilla.org/integration/fx-team/rev/eb4a3baac2c0

Comment 9

[Florian Quèze [:florian]]

Comment on attachment 8562754 [details] [diff] [review]
Disable for 37

Approval Request Comment
[Feature/regressing bug #]: bug 1101654.
[User impact if declined]: See the bugs marked as blocked by this one.
[Describe test coverage new/current, TreeHerder]: N/A
[Risks and why]: none; just pref'ing off the panel.
[String/UUID change made/needed]: none.

Comment 10

[Lawrence Mandel [:lmandel] (use needinfo)]

Gavin beat me to the approval. Glad to see that this feature is simply being preffed off in 37 and properly removed in 38.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/fe7cf0796f85

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/eb4a3baac2c0

Comment 13

[[github robot]]

Commit pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/b26304d649771e78a5c48c877fbd020b3cb08170
Bug 1123620 - remove the one-time intro popup for the new searchbox UI, r=Mossop.