1124883 - Add missing styles for about:support for modern theme (also to hide the Reset SeaMonkey box again)

Status: RESOLVED FIXED

(SeaMonkey :: Themes, defect)

Description

[rsx11m]

There have been some extensions to Toolkit's aboutSupport.css file which need to be ported to modern. In particular, a "#reset-box { visibility: hidden; }" was introduced with bug 948883 mozilla-central changeset 12b62c93d740. With the removal of the respective inline style, this caused an unhiding of the "Reset SeaMonkey" box and button to reset the profile when the modern theme is used, effective with SM 2.28 already.

This bug aims for just adding the missing styles (where it would have been better to add a hidden="true" attribute to the <div> in question, but maybe that doesn't work that well in XHTML so they've picked the hard-wired style definition).

SeaMonkey 2.32 got affected by a string change per bug 1063702 mozilla-central changeset 38ce31cc9334 which replaced "Reset" with "Refresh" (which doesn't make sense at all given that in SeaMonkey that button will actually wipe out all mail/news settings as well, thus its current label is absolutely misleading).

That opens the question if are we supposed to see that box at all? If there are occasions where the button is exposed to the user, we should override aboutSupport.dtd with scarier versions based on the old strings, but that would be for another bug report (not worth filing it and for localizers to translate them until we know that the box is actually shown in SeaMonkey's context, currently or some time in the future, and not just by accident).

Comment 1

[rsx11m]

Attachment: Proposed patch

This adds the missing styles from bug 717070 and accounts for bug 948883 changes.
Basically copy-pasted from Toolkit's version with the color scheme adjusted.

Comment 2

[[e-mail]]

Comment on attachment 8553357 [details] [diff] [review]
Proposed patch

FYI the reset box is only made visible if a self-migrator exists. One approach might be to restore our deleted 1.x migrator and tweak it to use 2.x as a source instead (possibly based on the Thunderbird migrator). (This would of course resolve your concern about losing mail accounts - they would get migrated too.)

Comment 3

[rsx11m]

Yeah, thanks - Ratty explained it to me on MozillaZine. The question is what we think is useful here and worth the effort (and I'd still would like to change those fuzzy strings back if we do so).

Anyway, push for comm-central for now, and I'm going to nominate this for the branches.

Comment 4

[rsx11m]

Comment on attachment 8553357 [details] [diff] [review]
Proposed patch

[Approval Request Comment]
Regression caused by (bug #): bug 948883
User impact if declined: sees a button for non-functional backend if modern theme is used
Testing completed (on m-c, etc.): works in c-c build, file modified hasn't been touched for a couple of years
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none

Comment 5

[Philip Chee]

Comment on attachment 8553357 [details] [diff] [review]
Proposed patch

a=me for comm-aurora and comm-beta

Comment 6

[Philip Chee]

Pushed to all branches:
http://hg.mozilla.org/comm-central/rev/3fc100224288
http://hg.mozilla.org/releases/comm-aurora/rev/a08093dbf871
http://hg.mozilla.org/releases/comm-beta/rev/24e8e9391b08

Comment 7

[Ian Neal]

Comment on attachment 8553357 [details] [diff] [review]
Proposed patch

[Triage Comment]
a=me

Comment 8

[rsx11m]

Thanks Ian, is a dot release for 2.32 on the horizon?
Anyway, push for comm-release if that's the case.

Comment 9

[Philip Chee]

http://hg.mozilla.org/releases/comm-release/rev/075d3ffc4d28