1125007 - [Text Selection] "Loading" during adding smart collection should not be selected

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Hermes Cheng (inactive after July 27, 2015)]

*Description
As a user, I don't want to select "Loading" during adding a smart collection.

*Steps:
1. choose a smart collection and add it.
2. when "Loading", long tap "Loading"

*Expected result:
nothing happen

*Actual result:
"Loading" is selected and copy & paste dialog jumps...


*Video: https://www.youtube.com/watch?v=0CU09OSnRcA

*Environment:
Build ID               20150122162504
Gaia Revision          237008137f6d72b9cad25ff4faff14ff2c40ac63
Gaia Date              2015-01-22 21:55:50
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/be24dd482a83
Gecko Version          37.0a2
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150122.194331
Firmware Date          Thu Jan 22 19:43:41 EST 2015
Bootloader             L1TC000118D0

Comment 1

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to master

Hi Kevin,
could you review this patch?
Thanks.

Comment 2

[Kevin Grandon :kgrandon]

Comment on attachment 8553647 [details] [review]
PR to master

lgtm.

Comment 3

[Kevin Grandon :kgrandon]

In master: https://github.com/mozilla-b2g/gaia/commit/8709f06ed3e8abcc9c73509b18b2cf0d1234e6ad

Comment 4

[Hermes Cheng (inactive after July 27, 2015)]

Hi Kevin, could you please also land the patch to v2.2?

Comment 5

[Kevin Grandon :kgrandon]

(In reply to Hermes Cheng[:hermescheng] from comment #4)
> Hi Kevin, could you please also land the patch to v2.2?

Just need to ask for approval for this. Generally the patch author does this.

Comment 6

[Kevin Grandon :kgrandon]

Comment on attachment 8553647 [details] [review]
PR to master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Missing CSS for text selection.
[User impact] if declined: Edge case, but potentially poor UX in collections.
[Testing completed]: Manual testing.
[Risk to taking this patch] (and alternatives if risky): Low risk, small css-only change,
[String changes made]: None.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/80d5b797fd0497a7e3337b7798a21b2e1219681a

Comment 8

[Yeojin Chung [:YeojinC]]

This issue is verified fixed on Flame 2.2 and Master.

Result: "Loading" during adding smart collection is not selectable. 
 
Device: Flame 2.2 (319mb, full flash)
Build ID: 20150130002501
Gaia: d6141fa3208f224393269e17c39d1fe53b7e6a05
Gecko: 63b63054948d
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0a2 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Device: Flame Master (319mb, full flash)
Build ID: 20150130010210
Gaia: 8238eeacc7030b2cdbf7ab4eba2f36779b702599
Gecko: 29b05d283b00
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0