1125075 - [Flame][Settings]There are reduplicative years in year list of Age Verification page.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: FxA, defect)

Description

[Coler]

Attachment: logcat_1554.txt

[1.Description]:
[Flame][v2.2][Settings]There are reduplicative years in age list of Age Verification page after user back to Age Verifycation list from Create Password page. 
Found time:15:54
Attachment:logcat_1554.txt &video.mp4

[2.Testing Steps]: 
1.Enter Settings -> Firefox accounts.
2.Click 'Create account or sign in'.
3.Enter email address and then tap next.
4.Select "2002 or earlier" and then tap Next..
5.Tap Back.
6.Open age list and check.

[3.Expected Result]: 
6.There is no reduplicative years in year list.

[4.Actual Result]: 
6.There are reduplicative years in year list.

[5.Reproduction build]: 
Flame 2.2:
Gaia-Rev        e4f9b5da3751798f9cc5d95f302c30722cc11fca
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/4a90da67661e
Build-ID        20150122002808
Version         37.0a2
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150122.041326
FW-Date         Thu Jan 22 04:13:37 EST 2015
Bootloader      L1TC000118D0

[6.Reproduction Frequency]: 
Always Recurrence,5/5

[7.TCID]: 
Free Test

Comment 1

[Coler]

Attachment: video.mp4

Comment 2

[Eric Chang [:ericcc] [:echang]]

Set 2.2? for regression.

Comment 3

[Coler]

We have tested regression on Flame 2.2:

Last Working Environmental Variables:

Gaia-Rev        c2bf20d23851d5fda9f8f0ef0267db5f49152376
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/b9f40d0310d5
Build-ID        20150105030453
Version         37.0a1
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.mozilla.20150211.134931
FW-Date         Wed Feb 11 13:53:22 CST 2015
Bootloader      L1TC000118D0

First Broken Environmental Variables:

Gaia-Rev        4ceeff19086b2a2955f044ad923dcfa63a293de3
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/912036eeb024
Build-ID        20150105033341
Version         37.0a1
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.mozilla.20150211.134931
FW-Date         Wed Feb 11 13:53:22 CST 2015
Bootloader      L1TC000118D0

First Broken Gaia & Last Working Gecko - issue DOES repro

Gaia-Rev        4ceeff19086b2a2955f044ad923dcfa63a293de3
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/b9f40d0310d5
Build-ID        20150105030453
Version         37.0a1
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150210.041059
FW-Date         Tue Feb 10 04:11:10 EST 2015
Bootloader      L1TC000118D0

First Broken Gecko & Last Working Gaia - issue does NOT repro

Gaia-Rev        c2bf20d23851d5fda9f8f0ef0267db5f49152376
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/912036eeb024
Build-ID        20150105033341
Version         37.0a1
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150210.041059
FW-Date         Tue Feb 10 04:11:10 EST 2015
Bootloader      L1TC000118D0

Comment 4

[Eric Chang [:ericcc] [:echang]]

Forgot to flip that, set 2.2? for regression

Comment 5

[Stephany Wilkes]

Triage is blocking based on the fact that this is regression.

Comment 6

[Kai-Chih Hu [:khu]]

Chris, is this something that you can help? Thank you.

Comment 7

[Kai-Chih Hu [:khu]]

I found that, every time, after I pressed 'next' and pressed 'previous' to go to this page, all options are duplicated again.

Comment 8

[Chris Karlof [:ckarlof]]

Jared, are you familiar with this implementation? Can you spend a little time to repro, debug, and scope out the work needed to fix it?

Comment 9

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

I don't know what the underlying bug might be, but looking at changes within the regression window[1], I wonder if the bug was introduced by the fix for bug 1116986. Fernando, mind taking a look?

Comment 10

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Sorry, accidentally hit submit before including the github compare link:

https://github.com/mozilla-b2g/gaia/compare/c2bf20d23851d5fda9f8f0ef0267db5f49152376...4ceeff19086b2a2955f044ad923dcfa63a293de3

Comment 11

[Fernando Jiménez Moreno [:ferjm]]

Attachment: v1

Comment 12

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8576724 [details] [review]
v1

LGTM

Comment 13

[Fernando Jiménez Moreno [:ferjm]]

Thanks Alive!

Comment 14

[Fernando Jiménez Moreno [:ferjm]]

https://github.com/mozilla-b2g/gaia/commit/8aeb0130db6db129128be892ab3c226e044283c4

Comment 15

[Ryan VanderMeulen [:RyanVM]]

Please request Gaia v2.2 approval on this when you get a chance.

Comment 16

[Fernando Jiménez Moreno [:ferjm]]

Comment on attachment 8576724 [details] [review]
v1

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Firefox Accounts. Bug 1116986
[User impact] if declined: Bad UX. The user will see duplicated entries in the age selection form.
[Testing completed]: Manual tests. Unit test added.
[Risk to taking this patch] (and alternatives if risky): Very low. The change is isolated and only affects the FxA COPPA screen.
[String changes made]: None.

Comment 17

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/5020b799634b2e53cadf2e201581ba03ac484e1b

Comment 18

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

This issue is verified fixed on the latest Nightly Flame 3.0 and 2.2 builds.

Actual Results: The years do not repeat when going back to the age verification prompt.

Environmental Variables:
Device: Flame 3.0
BuildID: 20150323010204
Gaia: 9b6f3024e4d0e62dd057231f4b14abe1782932ab
Gecko: e730012260a4
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 39.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0

Environmental Variables:
Device: Flame 2.2
BuildID: 20150323002504
Gaia: 7f367fc98ffdd183f21d2cdfe20556ab877ece34
Gecko: 3ea0eaeda353
Gonk: ebad7da532429a6f5efadc00bf6ad8a41288a429
Version: 37.0 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0