Closed Bug 1125085 Opened 11 years ago Closed 11 years ago

Remove netperf from tree (because it's not open source)

Categories

(Firefox OS Graveyard :: General, defect)

x86
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: gerv, Assigned: mwu)

References

Details

Attachments

(1 file)

Firefox OS (trunk) contains the following files, which have a proprietary HP license - proprietary because it does not permit commercial use and so is not open source: external/netperf/NOTICE external/netperf/netserver.c external/netperf/netperf.c Example header: The enclosed software and documentation includes copyrighted works of Hewlett-Packard Co. For as long as you comply with the following limitations, you are hereby authorized to (i) use, reproduce, and modify the software and documentation, and to (ii) distribute the software and documentation, including modifications, for non-commercial purposes only. These files should be removed, as agreed with mwu in legal bug 1105382. Gerv
Attachment #8554060 - Flags: review?(kli)
Once this is removed from the manifests, we should probably also remove it from the mirror at git.mozilla.org .
Comment on attachment 8554060 [details] [review] (PR) Remove netperf from manifests LGTM. I filed bug 1125692 to remove the mirror from git.m.o.
Attachment #8554060 - Flags: review?(kli) → review+
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Michael, Once the mirror is removed, device build will be broken on v1.2, v1.3, v1.4, v2.0, v2.1 and v2.1s. So I think we should also uplift this patch to those branches. Do you agree? If you thick so, I will uplift to all branches.
Flags: needinfo?(mwu)
I uplifted locally and found that manifests in the following branches are using "netperf". v1.2 v1.3 v1.3t v1.4 v2.0 v2.1 v2.1s v2.2 I will update changes in all branches to remote when I got a feedback.
I only see builds on treeherder for 1.4 and up, so you can ignore everything older than 1.4. You can do all of them if you want though. Thanks for the uplift!
Flags: needinfo?(mwu)
There was a stray entry in dolphin.xml still on v2.2 that was causing Bumper Bot issues today. v2.2: https://github.com/mozilla-b2g/b2g-manifest/commit/10d28a6a590c9001b225545cfd5295d7a07fbfb5
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: