Closed
Bug 1125085
Opened 11 years ago
Closed 11 years ago
Remove netperf from tree (because it's not open source)
Categories
(Firefox OS Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: gerv, Assigned: mwu)
References
Details
Attachments
(1 file)
Firefox OS (trunk) contains the following files, which have a proprietary HP license - proprietary because it does not permit commercial use and so is not open source:
external/netperf/NOTICE
external/netperf/netserver.c
external/netperf/netperf.c
Example header:
The enclosed software and documentation includes copyrighted works
of Hewlett-Packard Co. For as long as you comply with the following
limitations, you are hereby authorized to (i) use, reproduce, and
modify the software and documentation, and to (ii) distribute the
software and documentation, including modifications, for
non-commercial purposes only.
These files should be removed, as agreed with mwu in legal bug 1105382.
Gerv
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #8554060 -
Flags: review?(kli)
Assignee | ||
Comment 2•11 years ago
|
||
Once this is removed from the manifests, we should probably also remove it from the mirror at git.mozilla.org .
Comment 3•11 years ago
|
||
Comment on attachment 8554060 [details] [review]
(PR) Remove netperf from manifests
LGTM. I filed bug 1125692 to remove the mirror from git.m.o.
Attachment #8554060 -
Flags: review?(kli) → review+
Comment 4•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment 5•11 years ago
|
||
Michael, Once the mirror is removed, device build will be broken on v1.2, v1.3, v1.4, v2.0, v2.1 and v2.1s. So I think we should also uplift this patch to those branches. Do you agree? If you thick so, I will uplift to all branches.
Flags: needinfo?(mwu)
Comment 6•11 years ago
|
||
I uplifted locally and found that manifests in the following branches are using "netperf".
v1.2
v1.3
v1.3t
v1.4
v2.0
v2.1
v2.1s
v2.2
I will update changes in all branches to remote when I got a feedback.
Assignee | ||
Comment 7•11 years ago
|
||
I only see builds on treeherder for 1.4 and up, so you can ignore everything older than 1.4. You can do all of them if you want though. Thanks for the uplift!
Flags: needinfo?(mwu)
Comment 8•11 years ago
|
||
Michael, Thanks! I think remove from all manifests could be better and it is done.
v1.2: https://github.com/mozilla-b2g/b2g-manifest/commit/e1d5cd89c3d890fd34442f7899194b4f6d64f045
v1.3: https://github.com/mozilla-b2g/b2g-manifest/commit/4c7e05eea4a0a35cbf80c16f53489100e2475f33
v1.3t: https://github.com/mozilla-b2g/b2g-manifest/commit/27d7e2c4a23c461b7dbb80fd5cc35212995a2354
v1.4: https://github.com/mozilla-b2g/b2g-manifest/commit/8487de6089f4e11e27626e5b61a93bf96417dfc5
v2.0: https://github.com/mozilla-b2g/b2g-manifest/commit/ca0fdae96c1d90ebf6c18e5c4defc724f8a9b533
v2.1: https://github.com/mozilla-b2g/b2g-manifest/commit/5b150b4d815338dd9b909af7fec6ece350fcbbe7
v2.1s: https://github.com/mozilla-b2g/b2g-manifest/commit/b1a6625a36f84186475081d4675b1e418534ee45
v2.2: https://github.com/mozilla-b2g/b2g-manifest/commit/20868534f6da5ede0c959fc0aed0795762ca08cb
Comment 9•10 years ago
|
||
There was a stray entry in dolphin.xml still on v2.2 that was causing Bumper Bot issues today.
v2.2: https://github.com/mozilla-b2g/b2g-manifest/commit/10d28a6a590c9001b225545cfd5295d7a07fbfb5
You need to log in
before you can comment on or make changes to this bug.
Description
•