Change the "log not parsed" message to include a link to the raw log

VERIFIED FIXED

Status

Tree Management
Treeherder
P3
normal
VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: emorley, Assigned: jfrench)

Tracking

Details

Attachments

(2 attachments)

(Reporter)

Description

3 years ago
If we haven't finished parsing the log - and so the Treeherder UI displays the "not parsed yet, will periodically refresh" message - we could help avoid user frustration by making it obvious how they can use the raw log in the meantime.

We should either:
a) Add "you can use the raw log button in the meantime" to the message (since I think people may not have seen the raw link button / think it's also deactivated like the log viewer one).
b) Or actually just link to the raw log in the explanation
(Reporter)

Updated

3 years ago
See Also: → bug 1125099
(Reporter)

Updated

3 years ago
Priority: P2 → P3
(Assignee)

Comment 1

3 years ago
How about:

Log status: No logs
Log status: Raw log available
Log status: Parsed

...with "Raw" a blue link to the raw log view
...with "Parsed" a blue link to the logviewer view

So both of those links act as an extra access point, in addition to our navbar icons.
(Assignee)

Updated

3 years ago
Flags: needinfo?(emorley)
(Assignee)

Comment 2

3 years ago
Noting here also, with recent bumps in concurrency of log parser workers (2>5) and perhaps even more soon, I haven't seen a lot of log parsing 'in progress' states lately across m-c or m-i.

Not that we don't want the best possible UX if we do hit it.
(Reporter)

Comment 3

3 years ago
I was meaning more the message text on the right/center panel, rather than the log parsing status field in the job details panel on the left.
Flags: needinfo?(emorley)
(Assignee)

Comment 4

3 years ago
Ah, ok. I will have a look.
(Assignee)

Updated

3 years ago
Assignee: nobody → tojonmz
Status: NEW → ASSIGNED
(Assignee)

Comment 5

3 years ago
Created attachment 8602983 [details]
logParsingInProgMsgProposed_rev1

Here's a proposed update, for feedback. Let me know if you'd like any tweaks to it :)
Attachment #8602983 - Flags: feedback?(emorley)
(Assignee)

Comment 6

3 years ago
Comment on attachment 8602983 [details]
logParsingInProgMsgProposed_rev1

Ed's good with the change, so I'll open a PR.
Attachment #8602983 - Flags: feedback?(emorley)
(Assignee)

Comment 7

3 years ago
Created attachment 8603351 [details] [review]
treeherder-ui-PR#516

Please see above PR for status and review.
Attachment #8603351 - Flags: review?(emorley)
(Reporter)

Comment 8

3 years ago
Comment on attachment 8603351 [details] [review]
treeherder-ui-PR#516

Looks good, thank you :-)
Attachment #8603351 - Flags: review?(emorley) → review+

Comment 9

3 years ago
Commit pushed to master at https://github.com/mozilla/treeherder-ui

https://github.com/mozilla/treeherder-ui/commit/8c9c99d1c596b151e9487c0baaebc053a01c91e3
Bug 1125094 - Improve the log parsing in-progress message
(Assignee)

Comment 10

3 years ago
Marking resolved fixed. I will verify on the next push to stage/prod.
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
(Assignee)

Comment 11

3 years ago
The log parsing is so quick on stage/prod it's been difficult to verify a job in this transition state.

I was just running a local vagrant and happened to see this messaging doing exactly what it should with my own slower server, so marking Verified based on that.
Status: RESOLVED → VERIFIED

Comment 12

3 years ago
Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/f7d9430787b48f7c438df5318fd93128887dc10e
Bug 1125094 - Improve the log parsing in-progress message
You need to log in before you can comment on or make changes to this bug.