Restricted profiles - Allow admin to disable data collection

VERIFIED FIXED in Firefox 45

Status

()

defect
VERIFIED FIXED
4 years ago
3 years ago

People

(Reporter: jchaulk, Assigned: sebastian)

Tracking

(Blocks 1 bug)

Trunk
Firefox 45
All
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox45 verified)

Details

Attachments

(1 attachment)

Comment hidden (empty)
Blocks: FFB
OS: Windows 8.1 → Android
Hardware: x86_64 → All
Version: unspecified → Trunk
(Reporter)

Updated

4 years ago
Blocks: kidfox-v1

Updated

4 years ago
No longer blocks: kidfox-v1
No longer blocks: FFB
I think we should add a toggle to the admin settings to allow the admin to control "data choices", but if the crash reporter is disabled, we can't do "seamless crash recovery".
Summary: KidFox: Restricted profiles - Suppress the Crash Reporter dialog and enable seamless crash recovery → KidFox: Restricted profiles - Allow admin to disable crash reporter
Morphing this again to be about Crash Reporting/FHR/Telemetry.

I think we should add a single admin toggle to enable/disable this part of the settings UI, and if it is disabled, we should turn off data collection in the restricted profile.
Summary: KidFox: Restricted profiles - Allow admin to disable crash reporter → KidFox: Restricted profiles - Allow admin to disable data collection
Do you know when is the earliest we can land these changes? (Or when are we targeting?)
(In reply to Elvin Lee [:ellee] from comment #3)
> Do you know when is the earliest we can land these changes? (Or when are we
> targeting?)

We would need strings for this, so we'd be looking at Fx45.

Updated

4 years ago
Duplicate of this bug: 1219907
Assignee: nobody → s.kaspari
Status: NEW → ASSIGNED
If we want to have one toggle for all (Crash Reporting/FHR/Telemetry): What should be the default? ON or OFF? Should we make this dependent on the build (Nightly, Aurora, Beta, Release)?
(In reply to Sebastian Kaspari (:sebastian) from comment #6)
> If we want to have one toggle for all (Crash Reporting/FHR/Telemetry): What
> should be the default? ON or OFF? Should we make this dependent on the build
> (Nightly, Aurora, Beta, Release)?

We could make this depend on the channel. We could also make this default to the admin setting too. That would take care of using a different default per channel (we do this for admin already) and it gives us a way to set a reasonable default if the admin changes the setting in their own profile.
(In reply to Mark Finkle (:mfinkle) from comment #7)
> We could make this depend on the channel. We could also make this default to
> the admin setting too. That would take care of using a different default per
> channel (we do this for admin already) and it gives us a way to set a
> reasonable default if the admin changes the setting in their own profile.

The thing is: For normal profiles those things have different defaults but we want to boil them down to just one admin setting.
Summary: KidFox: Restricted profiles - Allow admin to disable data collection → Restricted profiles - Allow admin to disable data collection
Added Marshall to the thread - we should have a discussion about implementation choices as this affects user choice and privacy.
Bug 1125286 - Restricted profiles: Introduce toggle for "Data choices". r?margaret
Attachment #8693009 - Flags: review?(margaret.leibovic)
Comment on attachment 8693009 [details]
MozReview Request: Bug 1125286 - Restricted profiles: Introduce toggle for "Data choices". r?margaret

https://reviewboard.mozilla.org/r/26375/#review23827

::: mobile/android/base/restrictions/Restrictable.java:51
(Diff revision 1)
> -    LOCATION_SERVICE(13, "location_service", 0, 0),
> +    DATA_CHOICES(13, "data_coices",

Do we have control over the default value of the restrictions we show to the admin? Or are all things enabled (or disabled) by default?

If possible, I think we should default to enabling data choices.

We should also avoid showing the data reporing notification on startup if this section of settings is disabled:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/BrowserApp.java#1827
Attachment #8693009 - Flags: review?(margaret.leibovic)
(In reply to :Margaret Leibovic from comment #11)
> Do we have control over the default value of the restrictions we show to the
> admin? Or are all things enabled (or disabled) by default?

Yeah, we can do that. Currently all features in the list default to "off" but we can make this configurable.
Attachment #8693009 - Flags: review?(margaret.leibovic)
Comment on attachment 8693009 [details]
MozReview Request: Bug 1125286 - Restricted profiles: Introduce toggle for "Data choices". r?margaret

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/26375/diff/1-2/
Comment on attachment 8693009 [details]
MozReview Request: Bug 1125286 - Restricted profiles: Introduce toggle for "Data choices". r?margaret

https://reviewboard.mozilla.org/r/26375/#review23913

::: mobile/android/base/restrictions/RestrictedProfileConfiguration.java:35
(Diff revisions 1 - 2)
> +        configuration.put(Restrictable.DATA_CHOICES, true);

Thanks for updating this.
Attachment #8693009 - Flags: review?(margaret.leibovic) → review+
https://hg.mozilla.org/integration/fx-team/rev/82a82c57c723e3324241d8290b2255e3a9aba3db
Bug 1125286 - Restricted profiles: Introduce toggle for "Data choices". r=margaret

Comment 16

3 years ago
Is the plan now in place to default these data settings to "on"? That seems to be what is suggested here, if I am reading this bug correctly. We can't do that. We need to either use the settings from regular mode or turn all of the data collection off.
Flags: needinfo?(s.kaspari)
Flags: needinfo?(bbermes)
(In reply to Merwin from comment #16)
> Is the plan now in place to default these data settings to "on"? That seems
> to be what is suggested here, if I am reading this bug correctly. We can't
> do that. We need to either use the settings from regular mode or turn all of
> the data collection off.

Sorry, this has been a bit confusing here. We do not enable collecting data by default. We use the same defaults like in a regular profile. The device admin has the option to show/hide the settings for data collection. For example if a parent does not want the child to change these settings then the parent can hide them. So default "on" means here: By default the restricted profile can see the data choice settings and can opt-in.
Flags: needinfo?(s.kaspari)

Comment 18

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/82a82c57c723
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45
(In reply to Sebastian Kaspari (:sebastian) from comment #17)
> (In reply to Merwin from comment #16)
> > Is the plan now in place to default these data settings to "on"? That seems
> > to be what is suggested here, if I am reading this bug correctly. We can't
> > do that. We need to either use the settings from regular mode or turn all of
> > the data collection off.
> 
> Sorry, this has been a bit confusing here. We do not enable collecting data
> by default. We use the same defaults like in a regular profile. The device
> admin has the option to show/hide the settings for data collection. For
> example if a parent does not want the child to change these settings then
> the parent can hide them. So default "on" means here: By default the
> restricted profile can see the data choice settings and can opt-in.

Hi Sebastian. This seems to conflict with Barbara's note in bug #1222390 comment 20:

> I'm in favour of having the power giving to the admin at this stage to
> actually turn data choices on or off (all, i.e crash reporter, telemetry
> etc), and not show them as options under the restricted profile mode in
> Fennec.

Barbara, can you please confirm what the actual intended design approach is? In any case, Marshall noted that if the admin isn't directly controlling the data choices for the restricted profile, then we should be inheriting the settings from admin (rather than creating a new profile with its own defaults). If the admin has turned off all data collection, then the restricted profile shouldn't be created with some data collection on by default.
Flags: needinfo?(s.kaspari)
@Barbara, Margaret: Can you have a look at comment 19? I described my implementation in comment 17 - I thought this was what we agreed on; However it's not documented here.

Technically inheriting the settings from the admin is not really possible throughout. Whenever the settings on the admin profile are changed we have no mechanisms to let the restricted profile know. The only place we can change restricted profiles is from within Android's admin UI. Even there it might be problematic to set the defaults because this code is running in a broadcast receiver and we might need to access Gecko (or can we read all settings without Gecko running?). Note that currently the toggles do not actually change any settings here but just define whether we show the data choices settings to a restricted profile or not.
Flags: needinfo?(s.kaspari) → needinfo?(margaret.leibovic)

Updated

3 years ago
Depends on: 1232761
(In reply to Sebastian Kaspari (:sebastian) from comment #20)
> @Barbara, Margaret: Can you have a look at comment 19? I described my
> implementation in comment 17 - I thought this was what we agreed on; However
> it's not documented here.
> 
> Technically inheriting the settings from the admin is not really possible
> throughout. Whenever the settings on the admin profile are changed we have
> no mechanisms to let the restricted profile know. The only place we can
> change restricted profiles is from within Android's admin UI. Even there it
> might be problematic to set the defaults because this code is running in a
> broadcast receiver and we might need to access Gecko (or can we read all
> settings without Gecko running?). Note that currently the toggles do not
> actually change any settings here but just define whether we show the data
> choices settings to a restricted profile or not.

I filed bug 1232761 in response to this. I think we should just have the admin control the settings directly, and just hide the settings UI in the restricted profile.
Flags: needinfo?(margaret.leibovic)
Flags: needinfo?(bbermes)

Updated

3 years ago
QA Contact: mihai.ninu

Updated

3 years ago
QA Contact: mihai.ninu → flaviu.cos

Comment 22

3 years ago
Verified as fixed in Firefox 45 Beta 3;
Device: Nexus 7 (Android 5.1.1)
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.