1222390 - Reorganize admin UI for restricted profiles

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Family Friendly Browsing, defect)

Description

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: app-restrictions.png

Currently we show a bunch of toggles inside Android's settings UI for restricted profiles (See screenshot). This is overwhelming, tiring and boring. With the changes tracked by meta bug 1205615 we are going to add even more restrictions that should be configurable.

We can:

A) Continue to use Android's UI: Group settings, add descriptions and use just one toggle per group. For example:

   * Clear browsing history, disable private browsing, Disable master password, ..: Those things exists so that an admin can examine websites visited by the restricted profile.

   * Developer tools, Display options, Home customization, ... Those things simplify the UI and hide complexity.

   * (..)

B) Use a custom UI. Android allows to add a custom UI for configuring restrictions. For example Google Play Movies does that. This gives us more freedom to create a good experience. We still want to group things etc.

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: Example: Admin UI of "Play Movies & TV"

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

NI-ing Anthony to get some input how we could reorganize the admin UI.

Comment 3

[:Margaret Leibovic]

Note: there will be some changes to this UI in bug 1217073.

Barbara made a doc here comparing the old settings to what we'd like to have with the new settings organization:
https://docs.google.com/document/d/1ceOemuszhFJN1FW-kjTI8D40aR46VJcyVyazGDB2B_k/edit?ts=5630fed5

Comment 4

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

(In reply to :Margaret Leibovic from comment #3)
> Note: there will be some changes to this UI in bug 1217073.
> 
> Barbara made a doc here comparing the old settings to what we'd like to have
> with the new settings organization:
> https://docs.google.com/document/d/1ceOemuszhFJN1FW-
> kjTI8D40aR46VJcyVyazGDB2B_k/edit?ts=5630fed5

With this new list of Settings, I think we could move towards something more similar to comment 1. 

Sebastian, let's work together to get the list in comment 3, into the full page settings that you mention in comment 1.

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

(In reply to Anthony Lam (:antlam) from comment #4)
> Sebastian, let's work together to get the list in comment 3, into the full
> page settings that you mention in comment 1.

Alright! But maybe let's do this after bug 1189336. That one will remove the confusion regarding things like "Disable add-on installation OFF".

Comment 6

[Sebastian Kaspari (:sebastian; :pocmo)]

(In reply to Sebastian Kaspari (:sebastian) from comment #5)
> Alright! But maybe let's do this after bug 1189336. That one will remove the
> confusion regarding things like "Disable add-on installation OFF".

Actually, no. Let's define the new groups/toggles first. Otherwise I'll refactor and migrate restrictions that we later remove/replace.

Comment 7

[Barbara Bermes [:barbara] - NI please!]

I'd like to have legal first have a look at this, and I also don't know if we actually finalized that document.  

Maybe regroup first?

Comment 8

[Sebastian Kaspari (:sebastian; :pocmo)]

(In reply to Barbara Bermes [:barbara] from comment #7)
> I'd like to have legal first have a look at this, and I also don't know if
> we actually finalized that document.  

Legal might have opinions on data choices (-> bug 1125286) but we should be able to (re-)group our existing restrictions without them, right?

-

This is my first try to re-organize the restrictions:
https://docs.google.com/spreadsheets/d/1YpmBTtuobDAC0a7PP2Hbs-XDF6pkNvMi6P9cDMOkM50/edit?usp=sharing

I tried to put the existing (and some upcoming) restrictions into groups that describe the purpose why we added them in the first place. This is more about the groups itself than the wording/naming I used.

Thoughts?

Comment 9

[Barbara Bermes [:barbara] - NI please!]

Legal will let us know what things are mandatory to put in there for the parent to enable/disable, most importantly the data choices aspect.

Thanks for the document: I like your spreadsheet and its simplicity, I wonder how you came up with that list as some of the things we mentioned in the Google docs (second table) are not mentioned, e.g. Accessibility, Advanced etc. or did you want to move this under Simplified User Interface (as sub settings?).

Also we were discussing the idea of keeping all thins in menu>settings and have them rater disabled/greyed out for the kid mode.

Comment 10

[Sebastian Kaspari (:sebastian; :pocmo)]

(In reply to Barbara Bermes [:barbara] from comment #9)
> Thanks for the document: I like your spreadsheet and its simplicity, I
> wonder how you came up with that list as some of the things we mentioned in
> the Google docs (second table) are not mentioned, e.g. Accessibility,
> Advanced etc. or did you want to move this under Simplified User Interface
> (as sub settings?).

We might be talking about different things here. This bug is just about the admin UI for configuring a restricted profile: attachment 8684141 [details]. Not about settings. The settings reorganization is already done, isn't it?


(In reply to Barbara Bermes [:barbara] from comment #9)
> Also we were discussing the idea of keeping all thins in menu>settings and
> have them rater disabled/greyed out for the kid mode.

Oh, then we need a bug for this? This is news to me. What's the incentive behind this? Doesn't this cause confusion and frustration?

Comment 11

[Barbara Bermes [:barbara] - NI please!]

> We might be talking about different things here. This bug is just about the
> admin UI for configuring a restricted profile: attachment 8684141 [details].
> Not about settings. The settings reorganization is already done, isn't it?

I see your point, so yes and no:) Based on the settings re-org, Margaret noticed that certain things for FFB admin UI would change, and then we noticed while going through that exercise (word document) that we would want to make some changes (second table in the doc), e.g. remove the "disable" word and rather use positive language etc. We said we'd revisit the admin settings items once we start working on FFB phase 2.

> (In reply to Barbara Bermes [:barbara] from comment #9)
> > Also we were discussing the idea of keeping all thins in menu>settings and
> > have them rater disabled/greyed out for the kid mode.
> 
> Oh, then we need a bug for this? This is news to me. What's the incentive
> behind this? Doesn't this cause confusion and frustration?

Anthony brought this up, I'm good either or, hence this was not a final decision yet.

Comment 12

[:Margaret Leibovic]

Before meeting with legal, I think we should have a proposal of what things we would ideally want to include in this admin UI. I think we can get most of the way there without legal's input (e.g. removing our confusing use of the word "disable").

I want to come to a consensus about what we're trying to build here, since it's hard to make forward progress with so many uncertainties.

Barbara/Anthony, can you come up with a proposal before we meet with legal tomorrow? I think Sebastian's document is a great starting point.

Comment 13

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

After our meeting just now, I think the consensus is that we're going to clean up the language here, but stick with the current list of features we're allowing the Admin profile to enable/disable.

That should put us in a good spot for V2. 

Sebastian, should we just vidyo and clean up the copy together? we can leave this bug to track that work I guess?

Comment 14

[Barbara Bermes [:barbara] - NI please!]

Latest proposal including a second line item -> description (should be very explanatory to the parents what issues for their child could come up if enabled)


-----------------------------------------------------------------------------------------------------
Add-Ons:
Add-ons are small pieces of software that add new features or functionality. Note: Add-ons can disable certain restrictions.
-----------------------------------------------------------------------------------------------------
Private Browsing:
Private Browsing allows the family member to browse the Internet without saving any information about which sites and pages they’ve visited.
-----------------------------------------------------------------------------------------------------
Clear History:
The family-member can clear the browser history
-----------------------------------------------------------------------------------------------------
Advanced Settings:
Any advanced functionality such as import bookmarks, restore tabs, or automated updates. Turn off for simplified settings with less complexity, suitable for any family member.
-----------------------------------------------------------------------------------------------------
Camera & Microphone:
Camera and microphone can be used for real time communication on websites.
-----------------------------------------------------------------------------------------------------
Data Choices:
Settings to send usage information to Mozilla to help us make Firefox better.
-----------------------------------------------------------------------------------------------------
Block List
Use of a list of blocked websites with family sensitive content. See more detail about the list here[need link].

Elvin/Matej, I've tagged you in the Aha card as well: https://mozilla.aha.io/features/FENN-364

Please let me know if you prefer a meeting to hash this out.

Comment 15

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Awesome! thanks guys!

some questions: 

 - how can we make these more concise? For example, mentioning "Add-ons" multiple times in the same settings line item seems a bit repetitive... it'd be great if we could increase the "scan-ability" of these since they will live in a really long Settings list next to other prefs. It'd also help keep these line items less overwhelming (visually).

 - in the Android system, we typically try to use language that speaks to the user and addresses them with "you/your". Do you think it would be valuable to take a similar approach here with things like "the family member"?

 - it's important to note that a toggle switch will be next to these settings too. So perhaps seeing that on/off visual would affect this copy some how? (see screenshots above for reference)

thoughts? :)

Comment 16

[Barbara Bermes [:barbara] - NI please!]

all good Anthony, I think Matej probably can talk about this as well.

As for the "you/your" approach, we could say "your family member" etc.

Keep the ideas coming :)

Comment 17

[Matej Novak [:matej]]

(In reply to Barbara Bermes [:barbara] from comment #14)
> Latest proposal including a second line item -> description (should be very
> explanatory to the parents what issues for their child could come up if
> enabled)

Here are my edits:

-----------------------------------------------------------------------------------------------------
Add-ons:
Add features or functionality to Firefox. Note: Add-ons can disable certain restrictions.
-----------------------------------------------------------------------------------------------------
Private Browsing:
Allows family members to browse without saving information about the sites and pages they've visited.
-----------------------------------------------------------------------------------------------------
Clear History:
Allows family members to delete information about the sites and pages they've visited.
-----------------------------------------------------------------------------------------------------
Advanced Settings:
This includes importing bookmarks, restoring tabs and automated updates. Turn off for simplified settings suitable for any family member.
-----------------------------------------------------------------------------------------------------
Camera & Microphone:
Allows family members to engage in real time communication on websites.
-----------------------------------------------------------------------------------------------------
Data Choices:
Choose whether or not to send usage information to Mozilla to help make Firefox better.
-----------------------------------------------------------------------------------------------------
Block List
Block websites that include sensitive content. Learn more [need link].


Let me know if you have any questions.

Thanks!

Comment 18

[:Margaret Leibovic]

Should we be talking about family members explicitly? You can technically give your device to anyone in a restricted profile, so maybe this should be more generic?

Comment 19

[Barbara Bermes [:barbara] - NI please!]

Good question, and I see what you mean. While we use the restricted profile feature for Android tablets, we've been promoting it as FFB and want people to use it as such. So if we stick to this as a feature, I feel, especially to make it more clear what we are trying to do, we should use these words. Parents will automatically feel more addressed, I find.

Comment 20

[Barbara Bermes [:barbara] - NI please!]

(In reply to Matej Novak [:matej] from comment #17)
> (In reply to Barbara Bermes [:barbara] from comment #14)
> > Latest proposal including a second line item -> description (should be very
> > explanatory to the parents what issues for their child could come up if
> > enabled)
> 
> Here are my edits:

Thanks Matej, they read fine for me.

As for the family member terminology, Elvin could you please have a pass at it?

Anybody else? Thoughts?

One last thing I noticed we still need to confirm: the data choices on/off, is it really clear to the parent that by setting this to ON, this only means the option to turn it on or off will show up under the restricted profile mode in Fennec (under settings).
I'm in favour of having the power giving to the admin at this stage to actually turn data choices on or off (all, i.e crash reporter, telemetry etc), and not show them as options under the restricted profile mode in Fennec.

Comment 21

[Elvin Lee [:ellee] (no longer with Mozilla)]

> 
> One last thing I noticed we still need to confirm: the data choices on/off,
> is it really clear to the parent that by setting this to ON, this only means
> the option to turn it on or off will show up under the restricted profile
> mode in Fennec (under settings).
> I'm in favour of having the power giving to the admin at this stage to
> actually turn data choices on or off (all, i.e crash reporter, telemetry
> etc), and not show them as options under the restricted profile mode in
> Fennec.

My apologies for not making it to the previous meeting where this was discussed with Marshall. Is the latter the most recent front-runner proposal, or is it the former (admin decides if options are shown, not what the options are)?

Comment 22

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: MozReview Request: 1222390 - (Part 1) Restricted profiles: Always hide 'master password' setting. r?margaret

1222390 - (Part 1) Restricted profiles: Always hide 'master password' setting. r?margaret

Comment 23

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: MozReview Request: 1222390 - (Part 2) Restricted profiles: Always hide 'guest browsing'. r?margaret

1222390 - (Part 2) Restricted profiles: Always hide 'guest browsing'. r?margaret

Comment 24

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: MozReview Request: 1222390 - (Part 3) Restricted profiles: Always hide 'location services' (Stumbler) r?margaret

1222390 - (Part 3) Restricted profiles: Always hide 'location services' (Stumbler) r?margaret

Comment 25

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: MozReview Request: 1222390 - (Part 4) Restricted profiles: Add descriptions to restrictions. r?margaret

1222390 - (Part 4) Restricted profiles: Add descriptions to restrictions. r?margaret

Comment 26

[:Margaret Leibovic]

Comment on attachment 8692942 [details]
MozReview Request: 1222390 - (Part 1) Restricted profiles: Always hide 'master password' setting. r?margaret

https://reviewboard.mozilla.org/r/26353/#review23819

Comment 27

[:Margaret Leibovic]

Comment on attachment 8692943 [details]
MozReview Request: 1222390 - (Part 2) Restricted profiles: Always hide 'guest browsing'. r?margaret

https://reviewboard.mozilla.org/r/26355/#review23821

Comment 28

[:Margaret Leibovic]

Comment on attachment 8692944 [details]
MozReview Request: 1222390 - (Part 3) Restricted profiles: Always hide 'location services' (Stumbler) r?margaret

https://reviewboard.mozilla.org/r/26357/#review23823

Comment 29

[:Margaret Leibovic]

Comment on attachment 8692945 [details]
MozReview Request: 1222390 - (Part 4) Restricted profiles: Add descriptions to restrictions. r?margaret

https://reviewboard.mozilla.org/r/26359/#review23825

Comment 30

[Sebastian Kaspari (:sebastian; :pocmo)]

https://hg.mozilla.org/integration/fx-team/rev/64c69c8477072f48be49105e62d330f078bf602c
Bug 1222390 - (Part 1) Restricted profiles: Always hide 'master password' setting. r=margaret

https://hg.mozilla.org/integration/fx-team/rev/06d471012dd842534da3dd72cc6d52ac04cec169
Bug 1222390 - (Part 2) Restricted profiles: Always hide 'guest browsing'. r=margaret

https://hg.mozilla.org/integration/fx-team/rev/16566b2a4d84c94903a9f8b557f21c3dbaeb0ee0
Bug 1222390 - (Part 3) Restricted profiles: Always hide 'location services' (Stumbler) r=margaret

https://hg.mozilla.org/integration/fx-team/rev/1c6bc12e230b9ed34085ef70d1526909cab4e866
Bug 1222390 - (Part 4) Restricted profiles: Add descriptions to restrictions. r=margaret

Comment 31

[Barbara Bermes [:barbara] - NI please!]

(In reply to Elvin Lee [:ellee] from comment #21)
> > 
> > One last thing I noticed we still need to confirm: the data choices on/off,
> > is it really clear to the parent that by setting this to ON, this only means
> > the option to turn it on or off will show up under the restricted profile
> > mode in Fennec (under settings).
> > I'm in favour of having the power giving to the admin at this stage to
> > actually turn data choices on or off (all, i.e crash reporter, telemetry
> > etc), and not show them as options under the restricted profile mode in
> > Fennec.
> 
> My apologies for not making it to the previous meeting where this was
> discussed with Marshall. Is the latter the most recent front-runner
> proposal, or is it the former (admin decides if options are shown, not what
> the options are)?

Yes, the latter makes the most sense.

Comment 32

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/64c69c847707
https://hg.mozilla.org/mozilla-central/rev/06d471012dd8
https://hg.mozilla.org/mozilla-central/rev/16566b2a4d84
https://hg.mozilla.org/mozilla-central/rev/1c6bc12e230b

Comment 33

[Barbara Bermes [:barbara] - NI please!]

Release Note Request (optional, but appreciated)
[Why is this notable]: changes to Admin UI in FFB mode
[Suggested wording]: Simplified admin UI for family-friendly browsing on tablet in restricted profile 
[Links (documentation, blog post, etc)]:

Comment 34

[Sylvestre Ledru [:Sylvestre]]

Added to the 45 release notes with Barbara's wording.