1125364 - TypeError: content is null in AboutReaderListener

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[:Margaret Leibovic]

Spotted this in the console.

*************************
A coding exception was thrown in a Promise resolution callback.
See https://developer.mozilla.org/Mozilla/JavaScript_code_modules/Promise.jsm/Promise
Full message: TypeError: content is null
Full stack: AboutReaderListener.handleEvent/<@chrome://browser/content/content.js:513:15
Handler.prototype.process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:870:23
this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:749:7
this.PromiseWalker.scheduleWalkerLoop/<@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:691:37
*************************

Comment 1

[:Margaret Leibovic]

Attachment: Check to make sure content window isn't null after paring document

Similarly to bug 1125396, I found this while working on browser-chrome tests. I assume that content is null if the content window was destroyed while we were off parsing the document, so I think this is also a valid error case.

(I couldn't figure out how to make dependent review board reviews, so I'm just uploading this the old school way.)

Comment 2

[:Margaret Leibovic]

Attachment: Check to make sure content window isn't null after paring document (Android patch)

This logic is also in Fennec!

I should see if there's a way we could move this logic into a shared place... maybe in ReaderMode.jsm.

Comment 3

[:Margaret Leibovic]

https://hg.mozilla.org/integration/fx-team/rev/eddbe152474e
https://hg.mozilla.org/integration/fx-team/rev/0219a6e83e4b

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/eddbe152474e
https://hg.mozilla.org/mozilla-central/rev/0219a6e83e4b