1125582 - [WIFI]It will display "connected" one second before it connected failed

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect, P2)

Description

[sync-1]

Created an attachment (id=1116243)
 log
 
 PR Reporter:欧阳文丽
  contact:0752-2639312(61312)
 		
  DEFECT DESCRIPTION:
 >It will display "connected" one second before it connected failed.
 
  REPRODUCING PROCEDURES:
 1.Into setting -> wifi
 
 2.Click AP "TMC_RD_VAL_2F" to connect
 
 3.It will show "connected" one second before it connected failed --KO
 
  EXPECTED BEHAVIOUR:
 >It should not show "connected"
 
  ASSOCIATE SPECIFICATION:
 
  TEST PLAN REFERENCE:
 
  TOOLS AND PLATFORMS USED:
 
  USER IMPACT:
 
  REPRODUCING RATE:
 
  For FT PR, Please list reference mobile's behavior:

Comment 1

[sync-1]

Attachment: screenshot

Comment 2

[sync-1]

Attachment: log

Comment 3

[sync-1]

Hi mozilla colleagues,
 
 Please help to check the issue,it only come out for connect to wifi which open and limit mac addr,but device's wifi mac addr doesn't in list,expected behaviour is can't show connected but show connected failed,then reconnect this AP three times and forget it.
 
 PS:The issue is show connected for one second then connected fail.
 
 Any reproduce and other issue could call me,Office : 0752-2639130 (61130).
 
 
 Thanks!

Comment 4

[zhensen.su]

Hi Josh,

Could you help deliver it to corresponding engineers?

Thanks!

Comment 5

[Josh Cheng [:josh]]

Hi Kai-Zhen,
I suppose the current behavior is as expected?
Thanks!

Comment 6

[Kai-Zhen Li [:seinlin][:kli]]

I didn't find the SSID TMC_RD_VAL_2F (54 4D 43 5F 52 44 5F 56 41 4C 5F 32 46) in the attached log, so I have no idea at this moment.

Comment 7

[Kai-Zhen Li [:seinlin][:kli]]

From attached screen-captured file, we can see "TMC_RD_VAL_2F" is an ap with no security (open), could you describe the setting of "TMC_RD_VAL_2F" and the reason of connect failed?

Comment 8

[zhensen.su]

Hi Kai-zhen,

The ap is bind mac addr and security is open,but device wifi mac addr doesn't in ap bind mac addr list,so it‘s sure connect failed.

Comment 9

[Kai-Zhen Li [:seinlin][:kli]]

Zhensen, I setup an AP with security is open and enable mac filter. When I try to connect with my woodduck I can see "connecting... -> Open". I try many times and never see the status is "connected".

Can you verify with our build?

Comment 10

[zhensen.su]

Hi Kai-zhen,

Could you share your new version for me?

Comment 11

[Josh Cheng [:josh]]

Hi Zhensen,
Please try repo the issue with Mozilla Gaia/Gecko. Thanks!

User build image link is: http://pan.baidu.com/s/1hqnDBtM
Access code: 9c9u
unzip password: erT14moz

Comment 12

[zhensen.su]

Hi Kai-zhen,

I reproduce the issue use your build,you should connect with an AP success,then change to that open AP could reproduce.

Comment 13

[Josh Cheng [:josh]]

Hi ZhenSen,
Can you provide a video and clear STR for us?

Comment 14

[zhensen.su]

Hi Josh,

I have upload video&log on baidu cloud?The addr and pwd as below:
link: http://pan.baidu.com/s/1i3xgzf3 pwd: upw4

Thanks!

Comment 15

[zhensen.su]

Hi Kai-zhen,

Has any progress?

Comment 16

[Kai-Zhen Li [:seinlin][:kli]]

ZhenSen， I follow your steps and try many times, I didn't found the issue. Can you verify with another AP? Or use an android phone to try the same steps?

Comment 17

[zhensen.su]

Hi Kai-zhen,

I have found the reason cause the issue,it cause by the function WifiHelper.isConnected(network) doesn't suit open ap with need bind mac,because it hadn't network.security,so we can't judge whether it is connected.I have change 'return key === curkey;' to 'return (key === curkey)&&currentNetwork.known;'.It's OK now.

Thanks!

Comment 18

[Josh Cheng [:josh]]

Per comment 17. close as invalid.

Comment 19

[sync-1]

Hi dengwei, 
 
 The bug has been resolved, you can close it please.
 
 Thanks!

Comment 20

[GitHub Autolander Bot]

Attachment: [gaia] Seinlin:bug-1125582 > mozilla-b2g:v2.0m

Comment 21

[Kai-Zhen Li [:seinlin][:kli]]

Comment on attachment 8582308 [details] [review]
[gaia] Seinlin:bug-1125582 > mozilla-b2g:v2.0m

Henry, This is a patch for v2.0m branch. Would you mind review it? Thanks!

Comment 22

[Henry Chang [:hchang]]

(In reply to Kai-Zhen Li [:kli][:seinlin] from comment #21)
> Comment on attachment 8582308 [details] [review]
> [gaia] Seinlin:bug-1125582 > mozilla-b2g:v2.0m
> 
> Henry, This is a patch for v2.0m branch. Would you mind review it? Thanks!

It looks good to me! However, since it's a gaia patch, probably we need 
find a gaia reviewer as well. f+ by me. Thanks!

Comment 23

[Kai-Zhen Li [:seinlin][:kli]]

Comment on attachment 8582308 [details] [review]
[gaia] Seinlin:bug-1125582 > mozilla-b2g:v2.0m

Arthur, This is a patch for 2.0m branch. Would you mind review this patch? Thanks!

BTW, do you think if we should apply this patch to master and other branches?

Comment 24

[Arthur Chen [:arthurcc][inactive after 6/30]]

EJ, could you help review this patch? Thanks.

Comment 25

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8582308 [details] [review]
[gaia] Seinlin:bug-1125582 > mozilla-b2g:v2.0m

I meant to redirect the request to EJ. :p

Comment 26

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8582308 [details] [review]
[gaia] Seinlin:bug-1125582 > mozilla-b2g:v2.0m

Thanks Kai-Zhen, I left some comments in GitHub, please check it when you have time !  And for the question you mentioned in comment 23, because in latest Gaia, we already broke Wifi into several small modules, so codes that you should edit would be here :  https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/js/modules/wifi_utils.js#L95

Comment 27

[Kai-Zhen Li [:seinlin][:kli]]

Comment on attachment 8582308 [details] [review]
[gaia] Seinlin:bug-1125582 > mozilla-b2g:v2.0m

EJ, could you have a look to this PR? I think this is only for 2.0m as latest source has been re-factored. Thanks!

Comment 28

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8582308 [details] [review]
[gaia] Seinlin:bug-1125582 > mozilla-b2g:v2.0m

Thanks Kai-Zhen, r+ for this patch.

Comment 29

[Kai-Zhen Li [:seinlin][:kli]]

v2.0m: https://github.com/mozilla-b2g/gaia/commit/d4d2a2231e60609fafb64f52c09710ece287ea41

Comment 30

[Shally Li（leave from Mozilla）]

This bug has been successfully verified on latest Woodduck v2.0.

See attachment: verified_v2.0.mp4
Reproduce rate: 0/10

STR:
1.Go to Settings->Wi-Fi,and connect a wifi.
2.There is an ap which is "Open" and limits mac addr,and device's wifi mac addr doesn't in its list.
3.Tap on the ap.
**It does not show the "Connected" word anymore.

Device: Woodduck 2.0 build (Pass)
Build ID               20150505050314
Gaia Revision          d4d2a2231e60609fafb64f52c09710ece287ea41
Gaia Date              2015-04-23 02:23:38
Gecko Revision         da2415f6da13245e761b2497d333a1d6f42d826d
Gecko Version          32.0
Device Name            jrdhz72_w_ff
Firmware(Release)      4.4.2
Firmware(Incremental)  1430773895
Firmware Date          Tue May  5 05:12:02 CST 2015

Comment 31

[Shally Li（leave from Mozilla）]

Attachment: verified_v2.0m.mp4