Closed Bug 1125613 Opened 7 years ago Closed 3 years ago

"Undo" is impossible if a restart less add-on was removed from right click context menu in Add-ons manager

Categories

(Toolkit :: Add-ons Manager, defect)

x86_64
Windows 7
defect
Not set
normal

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: alice0775, Unassigned, Mentored)

References

Details

(Keywords: ux-consistency, Whiteboard: [good first bug])

This problem does not occur with old-style add-on.

Steps to reproduce:
1. install a restart less add-on
2. right click on the addon in Add-ons manager

Actual results:
No "Undo" link is available

Expected results:
"Undo" link should display
Keywords: ux-consistency
Blocks: 553494
I don't understand the steps to reproduce, after installing the add-on what are you expecting to undo?
Steps to reproduce:
1. Install a restart less add-on
2. Right click on the addon in Add-ons manager
3. Choose "Remove"
4. Attempt to Undo

Actual Results
"Undo" is impossible

Expected Results;
"Undo" link should be available
Whiteboard: [good first bug]
Mentor: dtownsend
Mentor: dtownsend → aswan
If this is your first contribution, please refer to https://wiki.mozilla.org/Add-ons/Contribute/Code on how to get started. 

If you need help getting started after you have set up your development environment, please needinfo :aswan.
(In reply to Caitlin Neiman [:caitmuenster] from comment #3)
> If this is your first contribution, please refer to
> https://wiki.mozilla.org/Add-ons/Contribute/Code on how to get started. 
> 
> If you need help getting started after you have set up your development
> environment, please needinfo :aswan.

Hi, this would be my first time contributing. I've built Firefox on my laptop and have Nightly installed. Is there a Read Me for this bug?
Hey dsemel, welcome! There's no Read Me for this bug, but I would recommend using https://searchfox.org/ to find the relevant code. :) 

I'm needinfo'ing the bug's mentor, aswan, for more direction. Aswan's currently out on PTO but he should be able to respond in the next couple of days. :)
Flags: needinfo?(aswan)
Okay, I will review and keep you posted.
(In reply to Caitlin Neiman [:caitmuenster] from comment #5)
> Hey dsemel, welcome! There's no Read Me for this bug, but I would recommend
> using https://searchfox.org/ to find the relevant code. :) 
> 
> I'm needinfo'ing the bug's mentor, aswan, for more direction. Aswan's
> currently out on PTO but he should be able to respond in the next couple of
> days. :)

Hi Caitlin,

Okay, I will review and keep you posted.

Thanks :)
(In reply to Caitlin Neiman [:caitmuenster] from comment #5)
> Hey dsemel, welcome! There's no Read Me for this bug, but I would recommend
> using https://searchfox.org/ to find the relevant code. :) 
> 
> I'm needinfo'ing the bug's mentor, aswan, for more direction. Aswan's
> currently out on PTO but he should be able to respond in the next couple of
> days. :)

Hi Caitlin,

I used SearchFox and perhaps the bug is in this file:

toolkit/locales/en-US/chrome/mozapps/extensions/extensions.dtd

I will continue working on it.
I just tried this and the bug appears to be fixed. I think it was resolved by bug 1482480.

Thanks for your interest dsemel but I don't think there's any work to be done here.
Status: NEW → RESOLVED
Closed: 3 years ago
Flags: needinfo?(aswan)
Resolution: --- → WORKSFORME
See Also: → 1482480
Thanks, Mark! 

dsemel, we're checking to see if the other good-first-bugs for this component are still valid. If they are, would you be interested in taking any of those up? 

There are also some good WebExtensions good-first-bugs available if you're interested in working on those. Here's the current list: https://mzl.la/2yq1XA8
(In reply to Caitlin Neiman [:caitmuenster] from comment #10)
> Thanks, Mark! 
> 
> dsemel, we're checking to see if the other good-first-bugs for this
> component are still valid. If they are, would you be interested in taking
> any of those up? 
> 
> There are also some good WebExtensions good-first-bugs available if you're
> interested in working on those. Here's the current list:
> https://mzl.la/2yq1XA8

Yes, I would be interested in other good-first-bugs for this same component. If none are found, I would also be interested in the bugs from WebExtensions list.
You need to log in before you can comment on or make changes to this bug.