1125613 - "Undo" is impossible if a restart less add-on was removed from right click context menu in Add-ons manager

Status: RESOLVED WORKSFORME

(Toolkit :: Add-ons Manager, defect)

Description

[Alice0775 White]

This problem does not occur with old-style add-on.

Steps to reproduce:
1. install a restart less add-on
2. right click on the addon in Add-ons manager

Actual results:
No "Undo" link is available

Expected results:
"Undo" link should display

Comment 1

[Dave Townsend [:mossop]]

I don't understand the steps to reproduce, after installing the add-on what are you expecting to undo?

Comment 2

[Alice0775 White]

Steps to reproduce:
1. Install a restart less add-on
2. Right click on the addon in Add-ons manager
3. Choose "Remove"
4. Attempt to Undo

Actual Results
"Undo" is impossible

Expected Results;
"Undo" link should be available

Comment 3

[Caitlin Neiman [:caitmuenster]]

If this is your first contribution, please refer to https://wiki.mozilla.org/Add-ons/Contribute/Code on how to get started. 

If you need help getting started after you have set up your development environment, please needinfo :aswan.

Comment 4

[dsemel]

(In reply to Caitlin Neiman [:caitmuenster] from comment #3)
> If this is your first contribution, please refer to
> https://wiki.mozilla.org/Add-ons/Contribute/Code on how to get started. 
> 
> If you need help getting started after you have set up your development
> environment, please needinfo :aswan.

Hi, this would be my first time contributing. I've built Firefox on my laptop and have Nightly installed. Is there a Read Me for this bug?

Comment 5

[Caitlin Neiman [:caitmuenster]]

Hey dsemel, welcome! There's no Read Me for this bug, but I would recommend using https://searchfox.org/ to find the relevant code. :) 

I'm needinfo'ing the bug's mentor, aswan, for more direction. Aswan's currently out on PTO but he should be able to respond in the next couple of days. :)

Comment 6

[dsemel]

Okay, I will review and keep you posted.

Comment 7

[dsemel]

(In reply to Caitlin Neiman [:caitmuenster] from comment #5)
> Hey dsemel, welcome! There's no Read Me for this bug, but I would recommend
> using https://searchfox.org/ to find the relevant code. :) 
> 
> I'm needinfo'ing the bug's mentor, aswan, for more direction. Aswan's
> currently out on PTO but he should be able to respond in the next couple of
> days. :)

Hi Caitlin,

Okay, I will review and keep you posted.

Thanks :)

Comment 8

[dsemel]

(In reply to Caitlin Neiman [:caitmuenster] from comment #5)
> Hey dsemel, welcome! There's no Read Me for this bug, but I would recommend
> using https://searchfox.org/ to find the relevant code. :) 
> 
> I'm needinfo'ing the bug's mentor, aswan, for more direction. Aswan's
> currently out on PTO but he should be able to respond in the next couple of
> days. :)

Hi Caitlin,

I used SearchFox and perhaps the bug is in this file:

toolkit/locales/en-US/chrome/mozapps/extensions/extensions.dtd

I will continue working on it.

Comment 9

[Mark Striemer [:mstriemer]]

I just tried this and the bug appears to be fixed. I think it was resolved by bug 1482480.

Thanks for your interest dsemel but I don't think there's any work to be done here.

Comment 10

[Caitlin Neiman [:caitmuenster]]

Thanks, Mark! 

dsemel, we're checking to see if the other good-first-bugs for this component are still valid. If they are, would you be interested in taking any of those up? 

There are also some good WebExtensions good-first-bugs available if you're interested in working on those. Here's the current list: https://mzl.la/2yq1XA8

Comment 11

[dsemel]

(In reply to Caitlin Neiman [:caitmuenster] from comment #10)
> Thanks, Mark! 
> 
> dsemel, we're checking to see if the other good-first-bugs for this
> component are still valid. If they are, would you be interested in taking
> any of those up? 
> 
> There are also some good WebExtensions good-first-bugs available if you're
> interested in working on those. Here's the current list:
> https://mzl.la/2yq1XA8

Yes, I would be interested in other good-first-bugs for this same component. If none are found, I would also be interested in the bugs from WebExtensions list.