Closed Bug 1482480 Opened 3 years ago Closed 3 years ago
Cannot remove addon through "Manage Extension" item in browser
Action context menu
bug 1457474 implemented a way to open a webextension's entry within about:addons through the context menu of its toolbar icon. it's not possible to uninstall/remove the addon that way though. str in a new profile: - install the privacy badger extension from https://addons.mozilla.org/en-US/firefox/addon/privacy-badger17/ - right-click the browseraction icon that's added to the toolbar - click on "manage extension" - click on "remove" on the addon page in about:addons that opened - nothing is happening at that point and the extension stays installed (if you are starting the steps from a newly opened tab, the about:addons page will close and the addon isn't getting uninstalled either)
I guess maybe some assumptions at https://searchfox.org/mozilla-central/source/toolkit/mozapps/extensions/content/extensions.js#1196 aren't true anymore? Oriol, want to take a look?
In bug 1457474 I just copied the code from bug 1413574 for pageActions, which have the same problem. I don't know the Add-ons Manager code, better find someone else.
hi, could you take a look as the author of bug 1413574?
This is a problem with the about:addons, not the UI that opens about:addons. I'm not sure who's working on that these days. I'll try to find someone to needinfo.
Oh David is listed as the triage owner -- David, do you know who might be a good person to investigate this bug?
Yuck, this code assumes that the only way to get to the detail view is by a click from the list view: https://searchfox.org/mozilla-central/rev/2466b82b729765fb0a3ab62f812c1a96a7362478/toolkit/mozapps/extensions/content/extensions.js#1201-1203
Using the Manage Extension menu item would try to go back to the list view to uninstall but there was no previous view so it would fail. TODO: Check dictionaries
I checked dictionaries, so feel free to ignore that comment.
David, should this be a priority to fix for 62? What do you think?
Comment on attachment 9000161 [details] Bug 1482480 - Fix removing add-on from Manage Extension menu item r?aswan Andrew Swan [:aswan] has approved the revision.
Attachment #9000161 - Flags: review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/f2abc57ccd74 Fix removing add-on from Manage Extension menu item r=aswan
This is also possible through the Manage Extension item in the page action context menu. I believe this code will fix that, too.
Please nominate this for Beta approval when you get a chance.
Comment on attachment 9000161 [details] Bug 1482480 - Fix removing add-on from Manage Extension menu item r?aswan Approval Request Comment [Feature/Bug causing the regression]: bug 1457474 [User impact if declined]: Removing an extension doesn't work from the Manage Extensions option [Is this code covered by automated tests?]: Yes [Has the fix been verified in Nightly?]: No [Needs manual test from QE? If yes, steps to reproduce]: See comment 0 [List of other uplifts needed for the feature/fix]: [Is the change risky?]: Low [Why is the change risky/not risky?]: Reduces dependence on previous state, has tests but is not verified on Nightly yet [String changes made/needed]: No
Attachment #9000161 - Flags: approval-mozilla-beta?
Comment on attachment 9000161 [details] Bug 1482480 - Fix removing add-on from Manage Extension menu item r?aswan Fix for regression in 62, has new tests. Let's uplift for beta 19.
Attachment #9000161 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Whoever takes this for verification, can you also check beta some time next week after beta 19 is released? Thanks!
Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:63.0) Gecko/20100101 Firefox/63.0 (20180817100105) I was able to reproduce the mentioned behavior on a Nightly build from 20180808100114. The issue not reproducible on the latest Nightly build from 20180817100105 using Windows 10 x64, Windows 7 x64, Ubuntu 18.04 and OS X 10.13. When installing the Privacy Badger add-on and then navigate from the context menu to Manage Extension (about:addons) and press the remove button, the add-on is successfully removed.
I've reproduced this issue on Beta 62.0b18. The issue has been verified as fixed on Beta 62.0b19 using Windows 10, Windows 7, Ubuntu 18.04 and OS X 10.13.
You need to log in before you can comment on or make changes to this bug.