1125630 - Cannot upload demo to Demo Studio

Status: RESOLVED WONTFIX

(developer.mozilla.org Graveyard :: Demo Studio / Dev Derby, defect)

Description

[Alon Zakai (:azakai)]

What did you do?
================
When I try to upload a new version of BananaBread, I get

> ZIP file contains an unacceptable file: low.data

low.data is a file containing binary data (output from the emscripten file packager; the data is BananaBread graphics assets)

I recall an email discussion from a long time ago that this might be an antivirus false positive.


What happened?
==============
.

What should have happened?
==========================
.

Is there anything else we should know?
======================================

Comment 1

[Alon Zakai (:azakai)]

Attachment: low.zip

Here is a zip of the file it has a problem with.

Comment 2

[Luke Crouch [:groovecoder]]

We don't have *real* anti-virus scans on the MDN demo studio. We do have a DEMO_MIMETYPE_BLACKLIST [1] as a security precaution. We use python-magic [2] to detect the mime types. We recently added [3] a DEMO_BLACKLIST_OVERRIDE_EXTENSIONS setting [4] which has `datagz` in it.

:azakai - would that work for BananaBread? I.e., to gzip the data file and call it low.datagz ?

[1] https://github.com/mozilla/kuma/blob/master/kuma/demos/models.py#L60-L108
[2] https://github.com/ahupp/python-magic
[3] https://bugzilla.mozilla.org/show_bug.cgi?id=1095649
[4] https://github.com/mozilla/kuma/blob/master/settings.py#L921-L925

Comment 3

[Alon Zakai (:azakai)]

Not easily, we expect to receive a normal file, not a gzipped file. If it is gzipped, we'd need to gunzip it ourselves on the client manually, which in JS isn't so bad, but these files are quite massive.

Comment 4

[Luke]

@Luke Crouch
Is is possible to make an exception/whitelist for BananaBread so we can get an updated version online?

Comment 5

[Luke Crouch [:groovecoder]]

We have no tooling to make exceptions for specific demos.

The easiest way to get the updated version online would be to add the .data extension to the exception list. But that means any demo uploader could put a .data file in their demo.

Is there a deadline by which we need to make a call? E.g., an event where we want to show BananaBread?

Comment 6

[Alon Zakai (:azakai)]

No deadline that I'm aware of. Just that the demo is currently broken and it would be nice to update it, a few people have noticed and asked us to.

Comment 7

[Luke Crouch [:groovecoder]]

I added it to our dev Inbox to discuss next week if we're okay to open '.data' extension to everyone, and/or how much work it might take to make demo-specific exceptions.

Comment 8

[Luke Crouch [:groovecoder]]

:azakai - I added .data to our pass-thru file extension list, so you should be able to upload the demo now.

:cylia - is there a way for us to get insight into the developer.cdn.mozilla.net traffic so we can see if/how large demo files are being accessed?

:jezdez - needinfo? you and myself to get back to our validate_demo_zipfile method [1] sometime.

[1] https://github.com/mozilla/kuma/blob/00f2d650e509f5344e16b702a73bc991c247134b/kuma/demos/models.py#L661-L710

Comment 9

[C. Liang [:cyliang]]

There is nothing currently analyzing the CDN logs on an on-going basis.  My understanding is that we can obtain log files but they will include all properties being handled by that CDN provider, so the number of entries generated by stuff like product-delivery tend to make for large files. =)

It looks like logs are kept for about five days.  If it's useful for me to grab a sampling from those logs, let me know.

Comment 10

[Alon Zakai (:azakai)]

Upload worked for me, thanks!

Comment 11

[Jannis Leidel [:jezdez]]

:groovecoder I think it makes sense to file a bug in the "cleanup" component to fix that method.

Comment 12

[Luke Crouch [:groovecoder]]

Clearing my needinfo? now that https://bugzilla.mozilla.org/show_bug.cgi?id=1161176 is filed.

Comment 13

[Rob Hudson [:robhudson]]

Demo Studio has been decommissioned.

See bug 1223109.