1125758 - "Guest" is shown (instead of "Invitado") in the Room Call screen when a Desktop user joins that Room via link clicker

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Loop, defect)

Description

[Maria Angeles Oteo (:oteo)]

If setting Spanish as language in the device, when a Desktop user joins an invited Room via browser (no through Firefox Hello Desktop application, just doing copy-paste of the Room URL in the browser), in the Room call screen of the creator of the Room (mobile device), "Guest" is shown instead of "Invitado".

See https://bugzilla.mozilla.org/show_bug.cgi?id=1121997#c7

Comment 1

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Attachment: Proposed patch - WIP

This patch fixes the issue but is not the best way. We should locate the origin of the issue

Comment 2

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Fixed here: 20e2d0f#diff-a4c6f5bbbeda75f8117e5841c032ae1bL222

Comment 3

[Maria Angeles Oteo (:oteo)]

Reopening as the solution was not completed and we were able to reproduce the bug.

Assigning to Cristian, as he already has the fix, thanks to all of you!!

Comment 4

[Cristian Rodriguez (:crdlc)]

Attachment: Github pull request

Comment 5

[Cristian Rodriguez (:crdlc)]

master:

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/44421e07260dc5f450f6b1375befdb7fdc741d70

Comment 6

[Cristian Rodriguez (:crdlc)]

1.1.1:

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/d4d6d37a57294fc8991afc6b21734ba4dd13a8dd

Comment 7

[isabelrios]

Verified on Fire E 2.0 Loop 1.1.1/bd1a553