1121997 - [Loop] Wrong texts with mobile in spanish language.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Loop, defect)

Description

[Javier de Prado]

ENV:
Flame / Firefox 35.0
v2.0
Gecko-5f9dc54
Gaia-31d6c94
Loop master version, commit 51a04dd
Device Language: Spanish

.- "Rooms": It should be "Conversaciones" (like in Desktop)
.- In Room->Detail, "Invitees": It should be "Invitados"
.- Title In Room->Detail->Invitees, "Shared with": It should be "Compartido con"
.- Notification "Guest se ha unido a la room": It should be "Invitado se ha unido a la conversación".
.- In one stablished conversation/room screen, It shows "Guest", instead of "Invitado".
.- Option in Room->Detail the option is "Histórico", and title inside this option is "Historia": The literal text should be the same in both cases.

Comment 1

[Cristian Rodriguez (:crdlc)]

There are a bug related to strings because product/ux team has to provide us with these literals. Do you remember which is the number bug Maria?

Comment 2

[Maria Angeles Oteo (:oteo)]

Yes, this is the Bug 1102847

Comment 3

[Maria Angeles Oteo (:oteo)]

Removing the dependency with bug 1102847 as in that bug we only address the English strings.
Spanish strings are taking longer and we will handle in other bug, perhaps we can do it in this as they are almost ready.

Comment 4

[Maria Angeles Oteo (:oteo)]

Some comments for Javier: 

(In reply to Javier de Prado from comment #0) 
> .- "Rooms": It should be "Conversaciones" (like in Desktop)
According to UX/Product feedback, in Spanish "Rooms" will be "Salas"

> .- In Room->Detail, "Invitees": It should be "Invitados"
> .- Title In Room->Detail->Invitees, "Shared with": It should be "Compartido
> con"

According to UX/Product feedback, in Spanish will be "Compartida con" in both cases

> .- Option in Room->Detail the option is "Histórico", and title inside this
> option is "Historia": The literal text should be the same in both cases.

According to UX/Product feedback, in Spanish will be "Histórico"

Comment 5

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Attachment: Spanish strings

Comment 6

[Cristian Rodriguez (:crdlc)]

Comment on attachment 8553701 [details] [review]
Spanish strings

LGTM, thanks Fernando

Comment 7

[Maria Angeles Oteo (:oteo)]

Comment on attachment 8553701 [details] [review]
Spanish strings

Thanks a lot Fernando, all seems to be addressed!!

I've only seen one missing thing, when a Desktop user joins an invited Room via browser (no through Firefox Hello Desktop application, just doing copy-paste of the Room URL in the browser). 
When setting Spanish as language in the device, in the Room call screen of the creator of the Room (mobile device), "Guest" is shown instead of "Invitado".

Fernando, could you please fix that? As soon as it's ready, please, land the patch as German localizations will be done by Sebastian during the weekend and perhaps he misses some fixes addressed in this patch.

One minorlast change, proposed by Monica:

shareRoom = Compartir sala

that's the last one!, I promise!!

Comment 8

[Maria Angeles Oteo (:oteo)]

Setting ni to Sebastian so he can be aware of the landing of this patch

Comment 9

[Cristian Rodriguez (:crdlc)]

Comment on attachment 8553701 [details] [review]
Spanish strings

José, please take a look at https://github.com/frsela/firefoxos-loop-client/commit/0f50272a41739722cd8de1476e1432f334c49588 because you worked in the notification part and you have more context here than me.

Comment 10

[José Antonio Olivera Ortega [:jaoo]]

I'll review this in a bit

Comment 11

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 8553701 [details] [review]
Spanish strings

As we just commented offline let's take care of the new strings and file a new bug for the logic issues encountered here. Thanks!

Comment 12

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Landed: https://github.com/mozilla-b2g/firefoxos-loop-client/commit/d467428351db41e229521b1fe3fcaa1a38b2f121

Comment 13

[Maria Angeles Oteo (:oteo)]

(In reply to José Antonio Olivera Ortega [:jaoo] from comment #11)
> Comment on attachment 8553701 [details] [review]
> Spanish strings
> 
> As we just commented offline let's take care of the new strings and file a
> new bug for the logic issues encountered here. Thanks!

Bug 1125762 opened for addressing the logic issues.

Bug 1125758 opened for handling the issue reported in Comment 7

Comment 14

[mbarone]

Tested with Fire E commercial build. FxHello 1.1.1 (d4d6d37)