Closed Bug 1125762 Opened 10 years ago Closed 10 years ago

Necessary logic fixes to land Bug 1121997 (Spanish localizations)

Categories

(Firefox OS Graveyard :: Gaia::Loop, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: oteo, Assigned: frsela)

References

Details

Attachments

(1 file)

For landing bug 1121997 (Spanish localizations), we need to fix some code issues (no string changes) so we prefer to handle in a separate bug.
Blocks: 1121997
Assignee: nobody → frsela
Status: NEW → ASSIGNED
Summary: Necessary fixes to land Bug 1121997 (Spanish localizations) → Necessary logic fixes to land Bug 1121997 (Spanish localizations)
Attached file Proposed patch
Attachment #8554449 - Flags: review?(josea.olivera)
Attachment #8554449 - Flags: feedback?(crdlc)
Comment on attachment 8554449 [details] [review]
Proposed patch

LGTM, thanks
Attachment #8554449 - Flags: feedback?(crdlc) → feedback+
Comment on attachment 8554449 [details] [review]
Proposed patch

LGTM. r=me with nits addressed.

Thanks Fernando!
Attachment #8554449 - Flags: review?(josea.olivera) → review+
Nit addressed. Thank you Jaoo

Landed: https://github.com/mozilla-b2g/firefoxos-loop-client/commit/2767dfdbd010659656343ca11216f998c76241b0
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: