Closed Bug 112577 Opened 23 years ago Closed 23 years ago

message pane doesn't show focus ring

Categories

(SeaMonkey :: MailNews: Message Display, defect)

x86
Windows 95
defect
Not set
trivial

Tracking

(Not tracked)

VERIFIED FIXED
mozilla0.9.8

People

(Reporter: neil, Assigned: hewitt)

References

Details

(Keywords: regression)

Attachments

(2 files)

For some reason when I click on the message pane the focus ring doesn't appear,
possibly because the commandDispatcher is returning null for the focusedElement.
Attached patch Proposed patchSplinter Review
Keywords: patch, regression, review
Attachment #59674 - Flags: review+
CCing bryner because shaver tells me he knows about the command dispatcher.
I think there's already a bug on this.
QA Contact: esther → olgam
We need more details when there is no focus in Thread pane.
There are dif bugs regarding this.
*** Bug 112749 has been marked as a duplicate of this bug. ***
From duplicate I see "the message display window".
You refer to "message pane". It looks like that you both talk about Message Body
area. It's covered in bug 109193: Focus ring is only in the Thread pane, not in
Folder or Message Body pane. Do you mind if I mark it as duplicate as well?
I have no problems with the focus in the folder pane, so it could be mac-specific.
May we clarify the issue here? Now you say "no problems with the focus in the
folder pane". Also why Mac, bug shows Win 95.
I was talking about the message body area.
Thanks for raising the issue!

*** This bug has been marked as a duplicate of 109193 ***
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → DUPLICATE
Verified dup.
Status: RESOLVED → VERIFIED
Firstly, you shouldn't resolve and verify the same bug.
Secondly, my original point is that this report only applies to the message body
area, not to the Mac folder pane. My Windows folder pane focuses perfectly.
Status: VERIFIED → REOPENED
Resolution: DUPLICATE → ---
this one has been bothering me too
Assignee: sspitzer → hewitt
Status: REOPENED → NEW
Target Milestone: --- → mozilla0.9.8
Attached patch patchSplinter Review
This patch does a bit more than neil's earlier patch.  It cleans up some
incredibly ugly code in FocusRingUpdate_Mail and does a more explicit check to
see if the message pane is focused.
Comment on attachment 61006 [details] [diff] [review]
patch

I don't understand:
1. Why do you check the current focused element is the thread outliner, folder
outliner or message pane before setting the focus ring, becuase it must always
be one of the three. Or, you could just check for the message pane and use
:focus rules for the thread and folder panes.
2. Why don't you check for the message pane. If the attachment tree has the
focus then WhichPaneHasFocus should return the message pane.
3. focusedWindow looks like a cheap operation so it should be done first.
Alas, there is one other thing in the mail window that can get focus: the
sidebar, which is why I check if each of the three panes has the focus.
Status: NEW → ASSIGNED
Updating multiple bugs. This is a valid UI issue. Would be nice to have it fixed
if time allows.
if (!currentFocusedElement)
     return;

takes care of the sidebar, because it is never returned from WhichPaneHasFocus().

See also the combined patch attached to bug 102711.
fix checked in, updated after comments from neil
Status: ASSIGNED → RESOLVED
Closed: 23 years ago23 years ago
Resolution: --- → FIXED
var gSearchInput; missing from msgMail3PaneWindow.js (patch is in bug 102711).
thanks neil, just checked in that line
Verified on today's and yesterday build 2002-01-03.
Win 2K, Linux, Mac OSX.
Status: RESOLVED → VERIFIED
*** Bug 109193 has been marked as a duplicate of this bug. ***
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: