Closed
Bug 1125784
Opened 10 years ago
Closed 10 years ago
Remove JS_ConvertArguments
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla38
| Tracking | Status | |
|---|---|---|
| firefox38 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
References
Details
(Keywords: dev-doc-complete)
Attachments
(1 file)
|
14.22 KB,
patch
|
jorendorff
:
review+
|
Details | Diff | Splinter Review |
JS_ConvertArguments is unsafer (varargs) and slower than CallArgs + calling the conversion functions manually.
This patch fixes the handful of places (mostly shell/test functions) that still used it and removes it.
I also removed JS_ConvertValue, it's not used anywhere (and looks like it doesn't work for symbols).
Attachment #8554489 -
Flags: review?(jorendorff)
|
||
Updated•10 years ago
|
Keywords: dev-doc-needed
|
||
Updated•10 years ago
|
Attachment #8554489 -
Flags: review?(jorendorff) → review+
|
Assignee | |
Comment 1•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox38:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
|
||
Comment 4•10 years ago
|
||
Marked as obsolete:
https://developer.mozilla.org/en-US/docs/Mozilla/Projects/SpiderMonkey/JSAPI_reference/JS_ConvertArguments
https://developer.mozilla.org/en-US/docs/Mozilla/Projects/SpiderMonkey/JSAPI_reference/JS_ConvertArgumentsVA
https://developer.mozilla.org/en-US/docs/Mozilla/Projects/SpiderMonkey/JSAPI_reference/JS_ConvertValue
Keywords: dev-doc-needed → dev-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•