Created attachment 8554489 [details] [diff] [review] Patch JS_ConvertArguments is unsafer (varargs) and slower than CallArgs + calling the conversion functions manually. This patch fixes the handful of places (mostly shell/test functions) that still used it and removes it. I also removed JS_ConvertValue, it's not used anywhere (and looks like it doesn't work for symbols).
Attachment #8554489 - Flags: review?(jorendorff)
Attachment #8554489 - Flags: review?(jorendorff) → review+
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
status-firefox38: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
Marked as obsolete: https://developer.mozilla.org/en-US/docs/Mozilla/Projects/SpiderMonkey/JSAPI_reference/JS_ConvertArguments https://developer.mozilla.org/en-US/docs/Mozilla/Projects/SpiderMonkey/JSAPI_reference/JS_ConvertArgumentsVA https://developer.mozilla.org/en-US/docs/Mozilla/Projects/SpiderMonkey/JSAPI_reference/JS_ConvertValue
Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.