Remove JS_ConvertArguments

RESOLVED FIXED in Firefox 38

Status

()

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jandem, Assigned: jandem)

Tracking

({dev-doc-complete})

unspecified
mozilla38
Points:
---

Firefox Tracking Flags

(firefox38 fixed)

Details

Attachments

(1 attachment)

Posted patch PatchSplinter Review
JS_ConvertArguments is unsafer (varargs) and slower than CallArgs + calling the conversion functions manually.

This patch fixes the handful of places (mostly shell/test functions) that still used it and removes it.

I also removed JS_ConvertValue, it's not used anywhere (and looks like it doesn't work for symbols).
Attachment #8554489 - Flags: review?(jorendorff)
Attachment #8554489 - Flags: review?(jorendorff) → review+
Duplicate of this bug: 505903
https://hg.mozilla.org/mozilla-central/rev/0ae3113e0583
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in before you can comment on or make changes to this bug.