Closed Bug 1125932 Opened 9 years ago Closed 9 years ago

create initial update verify configs for win64 betas

Categories

(Release Engineering :: Release Automation: Other, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bhearsum, Assigned: bhearsum)

References

Details

Attachments

(1 file)

I think we just need to create empty files?
I pushed an empty config: https://hg.mozilla.org/build/tools/rev/5c7721d9e5c0

Leaving this open because I want to do some stuff of update verify config generation alongside bug 1125931.
OK, so even after fixing up patcher configs in bug 1125931, update verify configs still fail:
2015-01-26 16:20:24,660 - INFO - Removing ja-JP-mac locale from win64 platform for 36.0b4
Traceback (most recent call last):
  File "tools/scripts/updates/create-update-verify-configs.py", line 141, in <module>
    build_id = pc['release'][v]['platforms'][ftp_platform]
KeyError: 'win64'


I suspect this is because there's no "win64" in previous release sections. We probably need a short term hack to work around this (ie, if version < x and platform == "win64": do nothing)
(In reply to Ben Hearsum [:bhearsum] from comment #2)
> OK, so even after fixing up patcher configs in bug 1125931, update verify
> configs still fail:
> 2015-01-26 16:20:24,660 - INFO - Removing ja-JP-mac locale from win64
> platform for 36.0b4
> Traceback (most recent call last):
>   File "tools/scripts/updates/create-update-verify-configs.py", line 141, in
> <module>
>     build_id = pc['release'][v]['platforms'][ftp_platform]
> KeyError: 'win64'
> 
> 
> I suspect this is because there's no "win64" in previous release sections.
> We probably need a short term hack to work around this (ie, if version < x
> and platform == "win64": do nothing)

This patch fixes this by switching the update verify config creator to use PatcherConfig.getUpdatePaths. This method already returns the correct update paths when adding platforms, and using it also removes the need for the update verify config creator to do a bunch of checks about locales being added/dropped. I tested this by rebumping all of the update verify configs for the latest beta, release, and esr locally - they were 100% the same. I also faked out win64 addition by adding it to the 36.0b3 and 36.0b4 patcher config blocks. The update verify config ended up as expected:
release="36.0" product="Firefox" platform="WINNT_x86_64-msvc" build_id="20150122214638" locales="ach af an ar as ast az be bg bn-BD bn-IN br bs ca cs cy da de dsb el en-GB en-US en-ZA eo es-AR es-CL es-ES es-MX et eu fa ff fi fr fy-NL ga-IE gd gl gu-IN he hi-IN hr hsb hu hy-AM id is it ja kk km kn ko lij lt lv mai mk ml mr ms nb-NO nl nn-NO or pa-IN pl pt-BR pt-PT rm ro ru si sk sl son sq sr sv-SE ta te th tr uk vi xh zh-CN zh-TW" channel="beta-localtest" patch_types="complete partial" from="/firefox/releases/36.0b3/win64/%locale%/Firefox Setup 36.0b3.exe" aus_server="https://aus4.mozilla.org" ftp_server_from="http://stage.mozilla.org/pub/mozilla.org" ftp_server_to="http://stage.mozilla.org/pub/mozilla.org" to="/firefox/candidates/36.0b4-candidates/build1/win64/%locale%/Firefox Setup 36.0b4.exe"
Assignee: nobody → bhearsum
Status: NEW → ASSIGNED
Attachment #8556513 - Flags: review?(rail)
Attachment #8556513 - Flags: review?(rail) → review+
Attachment #8556513 - Flags: checked-in+
This worked fine (after factoring out unrelated issues due to bug 1074362) in our staging run. We should be fine in this regard for production now.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: